You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "Hangleton (via GitHub)" <gi...@apache.org> on 2023/02/13 10:43:56 UTC

[GitHub] [kafka] Hangleton commented on a diff in pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

Hangleton commented on code in PR #13078:
URL: https://github.com/apache/kafka/pull/13078#discussion_r1104284495


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -264,6 +265,8 @@ class ReplicaManager(val config: KafkaConfig,
     leaderPartitionsIterator.count(_.hasLateTransaction(currentTimeMs))
   }
 
+  def producerIdCount: Int = onlinePartitionsIterator.map(_.producerIdCount).sum

Review Comment:
   On multi-tenant clusters, having the breakdown of producer IDs by topic is important. What is the rationale to expose this metric at an aggregate level only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org