You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/10/01 05:01:01 UTC

Re: t/SMOKE on win32

On Tue, 30 Sep 2003, Steve Hay wrote:

> Randy Kobes wrote:
[ ... ]
> >Here's a first stab at a patch to get t/SMOKE running on
> >Win32. I tried to localize the Win32 changes by putting
> >them in their own sub. The full functionality is probably
> >not all there - it still needs more testing - but it does
> >seem workable in principle.
> >
> It didn't make any difference to mine :-(
>
> I applied the patch OK to a freshly built 1.99_10, but running "perl
> t/SMOKE" (from the top-level of the mp2 build tree) still outputs:
>
> =====
> C:\Temp\mod_perl-1.99_10>perl t/SMOKE
> *** Using random number seed: 999532463 (autogenerated)
> ***
> ------------------------------------------------------------
> *** [001-00-00] trying all tests 10 times
> !!! failed to start server
>  '.' is not recognized as an internal or external command,
> operable program or batch file.
> =====

Strange - there was an error like this from before by
trying to run ./TEST (from about line 122 of TestSmoke.pm),
but I thought that was fixed in the patch ... Can you tell
where this might be coming from? Also (just in case ...:),
did you do an 'nmake' after patching, so that the patched
TestSmoke.pm from lib/ gets copied over into blib/?

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/SMOKE on win32

Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
> 
>> Patches are welcome.
>>
>> BTW, my notebook has a slow HD and running 'make' in modperl-2.0, even 
>> without any compilations takes a minute and even longer.
> 
> 
> hey, no fair tossing out the 'patches welcome' mat just because you have 
> a slow workstation...
> 
> :)

smiley's noted, i wanted to stress that I see no point in making developer's 
life harder than it's already, be it a slow harddisk and what not, as long as 
it doesn't make other lives harder. So as long as we find a compromise that 
suits everybody we are cool. Hence the request for a patch, since it was you 
who were unhappy about the current state-of-rat.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/SMOKE on win32

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> Patches are welcome.
> 
> BTW, my notebook has a slow HD and running 'make' in modperl-2.0, even 
> without any compilations takes a minute and even longer.

hey, no fair tossing out the 'patches welcome' mat just because you have a 
slow workstation...

:)

--Geoff


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/SMOKE on win32

Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
> 
> 
> Stas Bekman wrote:
> 
>> Steve Hay wrote:
>>
>>> So presumably t/SMOKE uses Apache-Test/lib rather than blib/lib?
>>
>>
>>
>> All our tools try to use the live libs instead of blib, to make it 
>> easy to develop.
> 
> 
> which doesn't work at all for third party XS modules, which is why we 
> have those extra statements in modperl_inc.pl, and why we need to do 
> that extra.last.conf.in foo in order to have XS modules seen at all.

I wasn't talking about 3rd party modules, but mp2 and Apache-Test's internals. 
Please see below.

>> Imagine how error-prone would it be if one had to remember to run 
>> 'make' after a single change is done to a file in lib/ or 
>> Apache-Test/lib, not talking about the overhead.
> 
> 
> remembering to run 'make' between test runs is everyday life for most of 
> us :)  I even have an alias for it
> 
> alias test='make && perl -Mblib'
> 
> $ test t/01foo.t
> 
> personally, I'd rather see everything run out of blib - it just seems to 
> make the most sense overall, and it's closer to what users of the other 
> perl testing suites are used to.

-1 on removing it, as it'll turn the development cycle into a nightmare (at 
least for me). +1 on turning this feature on only for the MAINTAINER mode. 
Patches are welcome.

BTW, my notebook has a slow HD and running 'make' in modperl-2.0, even without 
any compilations takes a minute and even longer.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/SMOKE on win32

Posted by Geoffrey Young <ge...@modperlcookbook.org>.

Stas Bekman wrote:
> Steve Hay wrote:
> 
>> So presumably t/SMOKE uses Apache-Test/lib rather than blib/lib?
> 
> 
> All our tools try to use the live libs instead of blib, to make it easy 
> to develop.

which doesn't work at all for third party XS modules, which is why we have 
those extra statements in modperl_inc.pl, and why we need to do that 
extra.last.conf.in foo in order to have XS modules seen at all.

> Imagine how error-prone would it be if one had to remember 
> to run 'make' after a single change is done to a file in lib/ or 
> Apache-Test/lib, not talking about the overhead.

remembering to run 'make' between test runs is everyday life for most of us 
:)  I even have an alias for it

alias test='make && perl -Mblib'

$ test t/01foo.t

personally, I'd rather see everything run out of blib - it just seems to 
make the most sense overall, and it's closer to what users of the other perl 
testing suites are used to.

--Geoff


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/SMOKE on win32

Posted by Stas Bekman <st...@stason.org>.
Steve Hay wrote:

> So presumably t/SMOKE uses Apache-Test/lib rather than blib/lib?

All our tools try to use the live libs instead of blib, to make it easy to 
develop. Imagine how error-prone would it be if one had to remember to run 
'make' after a single change is done to a file in lib/ or Apache-Test/lib, not 
talking about the overhead.


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: t/SMOKE on win32

Posted by Steve Hay <st...@uk.radan.com>.
Randy Kobes wrote:

>On Tue, 30 Sep 2003, Steve Hay wrote:
>
>  
>
>>Randy Kobes wrote:
>>    
>>
>[ ... ]
>  
>
>>>Here's a first stab at a patch to get t/SMOKE running on
>>>Win32. I tried to localize the Win32 changes by putting
>>>them in their own sub. The full functionality is probably
>>>not all there - it still needs more testing - but it does
>>>seem workable in principle.
>>>
>>>      
>>>
>>It didn't make any difference to mine :-(
>>
>>I applied the patch OK to a freshly built 1.99_10, but running "perl
>>t/SMOKE" (from the top-level of the mp2 build tree) still outputs:
>>
>>=====
>>C:\Temp\mod_perl-1.99_10>perl t/SMOKE
>>*** Using random number seed: 999532463 (autogenerated)
>>***
>>------------------------------------------------------------
>>*** [001-00-00] trying all tests 10 times
>>!!! failed to start server
>> '.' is not recognized as an internal or external command,
>>operable program or batch file.
>>=====
>>    
>>
>
>Strange - there was an error like this from before by
>trying to run ./TEST (from about line 122 of TestSmoke.pm),
>but I thought that was fixed in the patch ... Can you tell
>where this might be coming from? Also (just in case ...:),
>did you do an 'nmake' after patching, so that the patched
>TestSmoke.pm from lib/ gets copied over into blib/?
>  
>
I've got it working now - I'd actually patched the 
blib/lib/Apache/TestSmoke.pm file itself (my patch program couldn't find 
a file to patch so it asked me, and that's what I gave it).  Following 
your comment above I've now copied the patched TestSmoke.pm into 
Apache-Test/lib/Apache as well, and now it's smoking!

So presumably t/SMOKE uses Apache-Test/lib rather than blib/lib?

- Steve


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org