You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/18 16:11:21 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request, #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
anchao opened a new pull request, #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097
## Summary
arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
remove the unused branch definition that does not really work
## Impact
N/A
## Testing
CI - Check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097#issuecomment-1102220337
old arm and mips need the similar modification too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097#discussion_r852254635
##########
arch/arm/src/armv7-m/Kconfig:
##########
@@ -122,53 +122,27 @@ config ARMV7M_DTCM
choice
prompt "Toolchain Selection"
- default ARMV7M_TOOLCHAIN_GNU_EABIW if TOOLCHAIN_WINDOWS
- default ARMV7M_TOOLCHAIN_GNU_EABIL if !TOOLCHAIN_WINDOWS
+ default ARMV7M_TOOLCHAIN_GNU_EABI
Review Comment:
please modify other arch too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
Posted by GitBox <gi...@apache.org>.
anchao commented on code in PR #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097#discussion_r852633936
##########
arch/arm/src/armv7-m/Kconfig:
##########
@@ -122,53 +122,27 @@ config ARMV7M_DTCM
choice
prompt "Toolchain Selection"
- default ARMV7M_TOOLCHAIN_GNU_EABIW if TOOLCHAIN_WINDOWS
- default ARMV7M_TOOLCHAIN_GNU_EABIL if !TOOLCHAIN_WINDOWS
+ default ARMV7M_TOOLCHAIN_GNU_EABI
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097#discussion_r852669279
##########
boards/z80/z80/z80sim/README.txt:
##########
@@ -151,8 +148,7 @@ site: http://sourceforge.net/projects/sdcc/files/ . Pre-built binaries are
available for Linux, macOS, and for Win32. Various SDCC options can be
selected with:
- CONFIG_Z80_TOOLCHAIN_SDCCL=y : SDCC for Linux, macOS or Cygwin (see below)
- CONFIG_Z80_TOOLCHAIN_SDCCW=y : SDCC for Win32
+ CONFIG_Z80_TOOLCHAIN_SDCC=y : SDCC for Linux, macOS or Cygwin (see below)
Review Comment:
"Linux, macOS or Cygwin" to "Win32, Linux, macOS or Cygwin"
##########
tools/ci/testlist/risc-v.dat:
##########
@@ -1 +1 @@
-/risc-v,CONFIG_RISCV_TOOLCHAIN_GNU_RVGL
+/risc-v,CONFIG_RISCV_TOOLCHAIN_GNU_RVG
Review Comment:
let's remove ,CONFIG_RISCV_TOOLCHAIN_GNU_RVG
##########
tools/ci/testlist/arm-01.dat:
##########
@@ -1,3 +1,3 @@
-/arm/[a]*,CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
+/arm/[a]*,CONFIG_ARMV7A_TOOLCHAIN_GNU_EABI
Review Comment:
remove ,CONFIG_ARMV7A_TOOLCHAIN_GNU_EABI
##########
tools/ci/testlist/macos.dat:
##########
@@ -17,9 +17,9 @@
# RISC-V
-/risc-v/bl602/bl602evb/configs/wifi,CONFIG_RISCV_TOOLCHAIN_GNU_RVGL
+/risc-v/bl602/bl602evb/configs/wifi,CONFIG_RISCV_TOOLCHAIN_GNU_RVG
-/risc-v/esp32c3/esp32c3-devkit/configs/wapi,CONFIG_RISCV_TOOLCHAIN_GNU_RVGL
+/risc-v/esp32c3/esp32c3-devkit/configs/wapi,CONFIG_RISCV_TOOLCHAIN_GNU_RVG
Review Comment:
remove ,CONFIG_RISCV_TOOLCHAIN_GNU_RVG
##########
arch/z80/src/z80/Toolchain.defs:
##########
@@ -29,8 +29,7 @@
# built to run on Windows as a POSIX toolchain. The various SDCC options are
# selected in the NuttX configuration with:
#
-# CONFIG_Z80_TOOLCHAIN_SDCCL=y : SDCC for Linux, macOS or Cygwin
-# CONFIG_Z80_TOOLCHAIN_SDCCW=y : SDCC for Win32
+# CONFIG_Z80_TOOLCHAIN_SDCC=y : SDCC for Linux, macOS or Cygwin
Review Comment:
"Linux, macOS or Cygwin" to "Win32, Linux, macOS or Cygwin"
##########
arch/z80/src/z80/Kconfig:
##########
@@ -7,17 +7,10 @@ if ARCH_CHIP_Z80
choice
prompt "Toolchain Selection"
- default Z80_TOOLCHAIN_SDCCW if TOOLCHAIN_WINDOWS
- default Z80_TOOLCHAIN_SDCCL if !TOOLCHAIN_WINDOWS
+ default Z80_TOOLCHAIN_SDCC
-config Z80_TOOLCHAIN_SDCCL
+config Z80_TOOLCHAIN_SDCC
bool "SDCC for Linux, macOS, or Cygwin"
Review Comment:
"Linux, macOS or Cygwin" to "Win32, Linux, macOS or Cygwin"
##########
tools/ci/testlist/macos.dat:
##########
@@ -17,9 +17,9 @@
# RISC-V
-/risc-v/bl602/bl602evb/configs/wifi,CONFIG_RISCV_TOOLCHAIN_GNU_RVGL
+/risc-v/bl602/bl602evb/configs/wifi,CONFIG_RISCV_TOOLCHAIN_GNU_RVG
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on pull request #6097: arch/armv[7|8]-m: Unify the toolchain definition of eabi/clang/iar for linux and windows
Posted by GitBox <gi...@apache.org>.
anchao commented on PR #6097:
URL: https://github.com/apache/incubator-nuttx/pull/6097#issuecomment-1102384124
> old arm and mips need the similar modification too.
Done for arm, mips have different toolchain in Win32 and Linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org