[GitHub] [ozone] errose28 commented on a change in pull request #2757: HDDS-5820. Intermittent failure in TestPipelinePlacementPolicy#testPickLowestLoadAnchor

[GitBox <gi...@apache.org>]

errose28 commented on a change in pull request #2757:
URL: https://github.com/apache/ozone/pull/2757#discussion_r745876985



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java
##########
@@ -264,6 +264,16 @@ public static boolean hasEnoughSpace(DatanodeDetails datanodeDetails,
   public abstract DatanodeDetails chooseNode(
       List<DatanodeDetails> healthyNodes);
 
+  /**
+   * Choose a datanode according to the policy, this function is implemented
+   * by the actual policy class.
+   *
+   * @param healthyNodes - Set of healthy nodes we can choose from.
+   * @return DatanodeDetails
+   */
+  public abstract DatanodeDetails chooseFirstNode(

Review comment:
       I don't think it's necessary to define this in the parent class, since it looks like all the container based implementations are not used. I think just defining `chooseFirstNode` as `private` in `PipelinePlacementPolicy` would suffice, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org