You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "BFergerson (via GitHub)" <gi...@apache.org> on 2023/03/31 15:55:22 UTC
[GitHub] [skywalking] BFergerson opened a new pull request, #10632: feat: support sumLabeled in MAL
BFergerson opened a new pull request, #10632:
URL: https://github.com/apache/skywalking/pull/10632
Added support for the `sumLabeled` function in MAL. The implementation is based off of `SumPerMinLabeledFunction` and the test is based off of `AvgLabeledFunctionTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10632: Support sumLabeled in MAL
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10632:
URL: https://github.com/apache/skywalking/pull/10632#issuecomment-1492241094
Let's maintain things as less as possible, although it is harmless.
When we have a metric with labels based aggregation, we will need this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] BFergerson closed pull request #10632: Support sumLabeled in MAL
Posted by "BFergerson (via GitHub)" <gi...@apache.org>.
BFergerson closed pull request #10632: Support sumLabeled in MAL
URL: https://github.com/apache/skywalking/pull/10632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] BFergerson commented on pull request #10632: Support sumLabeled in MAL
Posted by "BFergerson (via GitHub)" <gi...@apache.org>.
BFergerson commented on PR #10632:
URL: https://github.com/apache/skywalking/pull/10632#issuecomment-1492235009
I thought it was odd you could average by label but couldn't sum by label given it's more simple. Fair enough though, I'll implement it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #10632: Support sumLabeled in MAL
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #10632:
URL: https://github.com/apache/skywalking/pull/10632#issuecomment-1492222397
Is there any specific use case for this new function? We only should maintain the function we used. If you need this in a fork, you could re-build the package to involve this new in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org