[jira] [Closed] (FLINK-28207) Disabling webhook should also disable mutator

["Gyula Fora (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-28207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gyula Fora closed FLINK-28207.
------------------------------
    Resolution: Fixed

merged to main a2908f5b773573fe2b76dd6061512a27f698ec4f

> Disabling webhook should also disable mutator
> ---------------------------------------------
>
>                 Key: FLINK-28207
>                 URL: https://issues.apache.org/jira/browse/FLINK-28207
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kubernetes Operator
>            Reporter: Márton Balassi
>            Assignee: Gyula Fora
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: kubernetes-operator-1.1.0
>
>
> The configuration for the mutating webhook suggests that it is nested inside the (validating) webhook:
> https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/values.yaml#L73-L76
> Based on this I would expect that if I disable the top level webhook it also disables the mutator, however this is not the case:
> https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L19-L79
> https://github.com/apache/flink-kubernetes-operator/blob/main/helm/flink-kubernetes-operator/templates/webhook.yaml#L115-L148
> I do not see a use case currently where we would want the mutating webhook without having the validating one, so I suggest following the hierarchy that the helm configs imply. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)