You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/19 10:52:52 UTC
[GitHub] [flink] zhijiangW commented on a change in pull request #8761:
[FLINK-12842][network] Fix invalid check released state during
ResultPartition#createSubpartitionView
zhijiangW commented on a change in pull request #8761: [FLINK-12842][network] Fix invalid check released state during ResultPartition#createSubpartitionView
URL: https://github.com/apache/flink/pull/8761#discussion_r295236581
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java
##########
@@ -217,6 +218,24 @@ public void testAddOnBlockingPartition() throws Exception {
testAddOnPartition(ResultPartitionType.BLOCKING);
}
+ /**
+ * Tests {@link ResultPartition#createSubpartitionView(int, BufferAvailabilityListener)} would throw
Review comment:
Yes, my initial thought was when the registered partition was released to remove from `ResultPartitionManager`, then it would also throw `PartitionNotFoundException` during creating view in manger. I should adjust the comment properly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services