You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/05/14 02:24:44 UTC

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #672: [HUDI-113]: WIP Use Tuple2 over # delimited string

vinothchandar commented on a change in pull request #672: [HUDI-113]: WIP Use Tuple2 over # delimited string
URL: https://github.com/apache/incubator-hudi/pull/672#discussion_r283604068
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/index/bloom/HoodieBloomIndex.java
 ##########
 @@ -300,22 +302,22 @@ public boolean isImplicitWithStorage() {
    * recordKey ranges in the index info.
    */
   @VisibleForTesting
-  JavaPairRDD<String, Tuple2<String, HoodieKey>> explodeRecordRDDWithFileComparisons(
+  JavaPairRDD<Tuple2<String, String>, Tuple2<String, HoodieKey>> explodeRecordRDDWithFileComparisons(
 
 Review comment:
   yes.. what do you think? we will save shuffling two more strings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services