You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lodu (via GitHub)" <gi...@apache.org> on 2023/09/29 11:56:12 UTC
[GitHub] [superset] lodu opened a new pull request, #25461: fix(reporting): adhere to EMAIL_NOTIFICATIONS flag
lodu opened a new pull request, #25461:
URL: https://github.com/apache/superset/pull/25461
### SUMMARY
Backend now uses the config EMAIL_NOTIFICATIONS flag to determine the dryrun variable when sending emails via SMTP.
### TESTING INSTRUCTIONS
Set EMAIL_NOTIFICATIONS to False, and trigger an email report. You should receive an email.
Set EMAIL_NOTIFICATIONS to True, and trigger an email report. You shouldn't receive an email.
### ADDITIONAL INFORMATION
- [ x] Has associated issue:
https://github.com/apache/superset/issues/25459
- [ x] Required feature flags:
ALERT_REPORTS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(reporting): adhere to EMAIL_NOTIFICATIONS flag [superset]
Posted by "mdeshmu (via GitHub)" <gi...@apache.org>.
mdeshmu commented on PR #25461:
URL: https://github.com/apache/superset/pull/25461#issuecomment-1742958306
@sfirke isn't EMAIL_NOTIFICATIONS deprecated in favor of ALERT_REPORTS_NOTIFICATION_DRY_RUN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(reporting): adhere to EMAIL_NOTIFICATIONS flag [superset]
Posted by "lodu (via GitHub)" <gi...@apache.org>.
lodu closed pull request #25461: fix(reporting): adhere to EMAIL_NOTIFICATIONS flag
URL: https://github.com/apache/superset/pull/25461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(reporting): adhere to EMAIL_NOTIFICATIONS flag [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #25461:
URL: https://github.com/apache/superset/pull/25461#issuecomment-1743071487
@mdeshmu I wrote this on the linked issue but will add it here, this is probably a better place:
> I had started a PR to address the fact that EMAIL_NOTIFICATIONS had been replaced by ALERT_REPORTS_NOTIFICATION_DRY_RUN. I gave up on it and would happily delete my branch if your PR accomplishes this. Just linking mine for reference in case it's useful to you: https://github.com/apache/superset/pull/24047
@lodu thank for you this improvement. Are you able to eliminate the EMAIL_NOTIFICATIONS setting and update to use ALERT_REPORTS_NOTIFICATION_DRY_RUN properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(reporting): adhere to EMAIL_NOTIFICATIONS flag [superset]
Posted by "lodu (via GitHub)" <gi...@apache.org>.
lodu commented on PR #25461:
URL: https://github.com/apache/superset/pull/25461#issuecomment-1744343741
Thank you for the pointers.
Will have a look later this week!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org