You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by bhuvnesh chaudhary <bc...@pivotal.io> on 2016/02/19 01:59:45 UTC

Review Request 43748: Add alerts for HAWQ components status

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-15105
    https://issues.apache.org/jira/browse/AMBARI-15105


Repository: ambari


Description
-------

This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
- Master
- Standby
- Segment


Diffs
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 

Diff: https://reviews.apache.org/r/43748/diff/


Testing
-------

yes, manual.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119789
-----------------------------------------------------------


Ship it!




Ship It!

- Jonathan Hurley


On Feb. 18, 2016, 7:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119809
-----------------------------------------------------------


Ship it!




Ship It!

- Jayush Luniya


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119812
-----------------------------------------------------------


Ship it!




Ship It!

- Matt


On Feb. 18, 2016, 4:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review120659
-----------------------------------------------------------


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 6)
<https://reviews.apache.org/r/43748/#comment182118>

    'HAWQ Segments' (plural)



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 7)
<https://reviews.apache.org/r/43748/#comment182119>

    "number of inoperative HAWQ Segments" (plural) ('down HAWQ Segments' is fine - would be nice to use a better synonym) 
    
    "results of HAWQ Segments' process checks" (plural)


- Matt


On Feb. 24, 2016, 5:02 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 5:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_component_status.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py PRE-CREATION 
>   ambari-web/app/views/main/dashboard/widgets.js 8a86af6 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review120802
-----------------------------------------------------------


Ship it!




Ship It!

- jun aoki


On Feb. 25, 2016, 7:56 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2016, 7:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_component_status.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py PRE-CREATION 
>   ambari-web/app/views/main/dashboard/widgets.js 8a86af6 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/
-----------------------------------------------------------

(Updated Feb. 25, 2016, 7:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Changes
-------

Updated description.


Bugs: AMBARI-15105
    https://issues.apache.org/jira/browse/AMBARI-15105


Repository: ambari


Description
-------

This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
- Master
- Standby
- Segment


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_component_status.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py PRE-CREATION 
  ambari-web/app/views/main/dashboard/widgets.js 8a86af6 

Diff: https://reviews.apache.org/r/43748/diff/


Testing
-------

yes, manual.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/
-----------------------------------------------------------

(Updated Feb. 25, 2016, 1:02 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Changes
-------

Thank you for your review folks. 
Applied feedback and added test cases.


Bugs: AMBARI-15105
    https://issues.apache.org/jira/browse/AMBARI-15105


Repository: ambari


Description
-------

This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
- Master
- Standby
- Segment


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/alerts/alert_component_status.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_alert_component_status.py PRE-CREATION 
  ambari-web/app/views/main/dashboard/widgets.js 8a86af6 

Diff: https://reviews.apache.org/r/43748/diff/


Testing
-------

yes, manual.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 4:50 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.


Changes
-------

Applied feedback


Bugs: AMBARI-15105
    https://issues.apache.org/jira/browse/AMBARI-15105


Repository: ambari


Description
-------

This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
- Master
- Standby
- Segment


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 

Diff: https://reviews.apache.org/r/43748/diff/


Testing
-------

yes, manual.


Thanks,

bhuvnesh chaudhary


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.

> On Feb. 19, 2016, 1:54 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json, line 26
> > <https://reviews.apache.org/r/43748/diff/1/?file=1258737#file1258737line26>
> >
> >     Was the alert tested with another port?

yes. Tested it on single node with port 5433.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119770
-----------------------------------------------------------


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119770
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 26)
<https://reviews.apache.org/r/43748/#comment181125>

    Was the alert tested with another port?


- Matt


On Feb. 18, 2016, 4:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Goutam Tadi <go...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119775
-----------------------------------------------------------


Ship it!




Ship It!

- Goutam Tadi


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On Feb. 18, 2016, 9:05 p.m., jun aoki wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json, line 24
> > <https://reviews.apache.org/r/43748/diff/1/?file=1258737#file1258737line24>
> >
> >     Is type OK for checking a process is down?
> >     I don't know if a type called "PROCESS", but otherwise maybe "SCRIPT" to issue same ps with process names?
> 
> bhuvnesh chaudhary wrote:
>     Good point. I see a possibility of some other process occupying the port and might be listening on it, even though Hawq process may be down. In that case, an alert will not be sent, but such occurence may be limited.
>     
>     Also, as a standard/recommended practice we should have hawq being run on reserved port, since if we let HAWQ run on the current unreserved port range, HAWQ component startup can also fail if some process is already occupying that port. That change should also resolve the issue mentioned above.
>     
>     Ensuring check for process name is something which we can possibily have an enhancement on alerts and add a field regex_pattern in alerts.json to search for the process on the port to avoid such issue, instead of creating a separate script for process check since type PORT is common across all the services and used similarly. The same issue can manifests for all the services.
>     
>     If you are okay, i will create a separate JIRA on alerts for enhancement and drop this issue here ?
>     and for ensuring that HAWQ is run on a reserved port range will work internally ?

Typically, yes, using a PORT to check and see if a process is down is good enough. Typically, if there's a WEB endpoint we'll use that. In cases where we also want to test functionality of the component, a SCRIPT alert will be written.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119778
-----------------------------------------------------------


On Feb. 18, 2016, 7:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.

> On Feb. 19, 2016, 2:05 a.m., jun aoki wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json, line 24
> > <https://reviews.apache.org/r/43748/diff/1/?file=1258737#file1258737line24>
> >
> >     Is type OK for checking a process is down?
> >     I don't know if a type called "PROCESS", but otherwise maybe "SCRIPT" to issue same ps with process names?

Good point. I see a possibility of some other process occupying the port and might be listening on it, even though Hawq process may be down. In that case, an alert will not be sent, but such occurence may be limited.

Also, as a standard/recommended practice we should have hawq being run on reserved port, since if we let HAWQ run on the current unreserved port range, HAWQ component startup can also fail if some process is already occupying that port. That change should also resolve the issue mentioned above.

Ensuring check for process name is something which we can possibily have an enhancement on alerts and add a field regex_pattern in alerts.json to search for the process on the port to avoid such issue, instead of creating a separate script for process check since type PORT is common across all the services and used similarly. The same issue can manifests for all the services.

If you are okay, i will create a separate JIRA on alerts for enhancement and drop this issue here ?
and for ensuring that HAWQ is run on a reserved port range will work internally ?


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119778
-----------------------------------------------------------


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119778
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 24)
<https://reviews.apache.org/r/43748/#comment181131>

    Is type OK for checking a process is down?
    I don't know if a type called "PROCESS", but otherwise maybe "SCRIPT" to issue same ps with process names?


- jun aoki


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by bhuvnesh chaudhary <bc...@pivotal.io>.

> On Feb. 19, 2016, 1:55 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json, line 20
> > <https://reviews.apache.org/r/43748/diff/1/?file=1258737#file1258737line20>
> >
> >     Capitalize M for master.
> >     The description would show up on the UI

Will do.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119772
-----------------------------------------------------------


On Feb. 19, 2016, 12:59 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 12:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119772
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 20)
<https://reviews.apache.org/r/43748/#comment181126>

    Capitalize M for master.
    The description would show up on the UI


- Matt


On Feb. 18, 2016, 4:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Jonathan Hurley <jh...@hortonworks.com>.

> On Feb. 18, 2016, 8:56 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json, line 49
> > <https://reviews.apache.org/r/43748/diff/1/?file=1258737#file1258737line49>
> >
> >     Should this be HOST? I believe it is more of a service level alert.

HAWQSEGMENT is a slave with cardinality of 1+ ... makes sense to keep it as HOST.


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119774
-----------------------------------------------------------


On Feb. 18, 2016, 7:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 7:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Matt <mi...@gmail.com>.

> On Feb. 18, 2016, 5:56 p.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json, line 49
> > <https://reviews.apache.org/r/43748/diff/1/?file=1258737#file1258737line49>
> >
> >     Should this be HOST? I believe it is more of a service level alert.
> 
> Jonathan Hurley wrote:
>     HAWQSEGMENT is a slave with cardinality of 1+ ... makes sense to keep it as HOST.

Thanks for clarifying Jonathon!


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119774
-----------------------------------------------------------


On Feb. 18, 2016, 4:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>


Re: Review Request 43748: Add alerts for HAWQ components status

Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43748/#review119774
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json (line 49)
<https://reviews.apache.org/r/43748/#comment181128>

    Should this be HOST? I believe it is more of a service level alert.


- Matt


On Feb. 18, 2016, 4:59 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43748/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2016, 4:59 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, jun aoki, Jonathan Hurley, Jayush Luniya, Oleksandr Diachenko, Richard Zang, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-15105
>     https://issues.apache.org/jira/browse/AMBARI-15105
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This patch introduces alerts for HAWQ components based on PORT. The below components are covered.
> - Master
> - Standby
> - Segment
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json 3119a0c 
> 
> Diff: https://reviews.apache.org/r/43748/diff/
> 
> 
> Testing
> -------
> 
> yes, manual.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>