You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/08/25 16:19:58 UTC

[GitHub] [drill] vvysotskyi opened a new pull request #2300: DRILL-7990: Unable to disable requireTail in HTTP storage plugin API

vvysotskyi opened a new pull request #2300:
URL: https://github.com/apache/drill/pull/2300


   # [DRILL-7990](https://issues.apache.org/jira/browse/DRILL-7990): Unable to disable requireTail in HTTP storage plugin API
   
   ## Description
   This issue is caused by the conflict of `@JsonInclude(JsonInclude.Include.NON_DEFAULT)` annotation and default behavior of `HttpApiConfig` to set `requireTail` to `true` when value is `null` (or absent). 
   Fixed by including the `requireTail` field explicitly. Fixed backward compatibility for the credentials provider.
   
   ## Documentation
   NA
   
   ## Testing
   Added UT, checked manually.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre merged pull request #2300: DRILL-7990: Unable to disable requireTail in HTTP storage plugin API

Posted by GitBox <gi...@apache.org>.

cgivre merged pull request #2300:
URL: https://github.com/apache/drill/pull/2300


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] vvysotskyi commented on pull request #2300: DRILL-7990: Unable to disable requireTail in HTTP storage plugin API

Posted by GitBox <gi...@apache.org>.

vvysotskyi commented on pull request #2300:
URL: https://github.com/apache/drill/pull/2300#issuecomment-905694319


   There is no need to list all fields in the builder. I've listed there only fields that require some special treatment, all other fields will be added by Lombok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org