You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "FrNecas (via GitHub)" <gi...@apache.org> on 2023/08/22 17:03:52 UTC

[GitHub] [arrow] FrNecas commented on a diff in pull request #35780: GH-15060: [JS] Add LargeUtf8 type

FrNecas commented on code in PR #35780:
URL: https://github.com/apache/arrow/pull/35780#discussion_r1301947907


##########
js/src/enum.ts:
##########
@@ -201,6 +201,7 @@ export enum Type {
     SparseUnion = -24,
     IntervalDayTime = -25,
     IntervalYearMonth = -26,
+    LargeUtf8 = -27,

Review Comment:
   I think it should be 20, according to the flatbuffers file that you get when you build the package (also the comment about 0-17) is probably outdated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org