You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/09/21 07:29:25 UTC
[GitHub] [incubator-echarts] ys4503 opened a new issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
ys4503 opened a new issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316
### Version
4.9.0
### Reproduction link
[https://jsfiddle.net/zg7mw5nf/](https://jsfiddle.net/zg7mw5nf/)
### Steps to reproduce
The line is not connected to points outside the zoom-in region when using dataZoom in a Line chart with xaxis type value. Try zooming between 6 and 9 in above JSFiddle Link
### What is expected?
The line should be connected to points outside the zoom-in region.
### What is actually happening?
The line is only connected to points inside the zoom-in region.
---
There should be scatterline type chart.
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] worldforce1 commented on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
worldforce1 commented on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730147111
I found a solution around this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] worldforce1 edited a comment on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
worldforce1 edited a comment on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730147111
I found a solution around this bug.
Just modify the source code of echart.js in function AxisProxy -> filterData, from:
var thisLeftOut = value < valueWindow[0]
var thisRightOut = value > valueWindow[1]
to
var thisLeftOut = value < valueWindow[0] && seriesData.get(dataDims[i], dataIndex+1) < valueWindow[0];
var thisRightOut = value > valueWindow[1] && seriesData.get(dataDims[i], dataIndex-1) > valueWindow[1];
Then set the filterMode option of dataZoom component to 'weakFilter'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-695950100
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] worldforce1 edited a comment on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
worldforce1 edited a comment on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730147111
I found a solution around this bug.
Just modify the source code of echart.js around line 81638, from:
`
var thisLeftOut = value < valueWindow[0]
var thisRightOut = value > valueWindow[1]
`
to
`
var thisLeftOut = value < valueWindow[0] && seriesData.get(dataDims[i], dataIndex+1) < valueWindow[0];
var thisRightOut = value > valueWindow[1] && seriesData.get(dataDims[i], dataIndex-1) > valueWindow[1];
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] worldforce1 edited a comment on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
worldforce1 edited a comment on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730147111
I found a solution around this bug.
Just modify the source code of echart.js in function AxisProxy -> filterData, from:
var thisLeftOut = value < valueWindow[0]
var thisRightOut = value > valueWindow[1]
to
var thisLeftOut = value < valueWindow[0] && seriesData.get(dataDims[i], dataIndex+1) < valueWindow[0];
var thisRightOut = value > valueWindow[1] && seriesData.get(dataDims[i], dataIndex-1) > valueWindow[1];
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] worldforce1 edited a comment on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
worldforce1 edited a comment on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730147111
I found a solution around this bug.
Just modify the source code of echart.js around line 81638 (in function AxisProxy -> filterData), from:
var thisLeftOut = value < valueWindow[0]
var thisRightOut = value > valueWindow[1]
to
var thisLeftOut = value < valueWindow[0] && seriesData.get(dataDims[i], dataIndex+1) < valueWindow[0];
var thisRightOut = value > valueWindow[1] && seriesData.get(dataDims[i], dataIndex-1) > valueWindow[1];
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] worldforce1 edited a comment on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
worldforce1 edited a comment on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730147111
I found a solution around this bug.
Just modify the source code of echart.js around line 81638, from:
var thisLeftOut = value < valueWindow[0]
var thisRightOut = value > valueWindow[1]
to
var thisLeftOut = value < valueWindow[0] && seriesData.get(dataDims[i], dataIndex+1) < valueWindow[0];
var thisRightOut = value > valueWindow[1] && seriesData.get(dataDims[i], dataIndex-1) > valueWindow[1];
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-695950100
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] ys4503 commented on issue #13316: Line is disconnected from points outside zoomed-in region in Line Chart with value type xaxis
Posted by GitBox <gi...@apache.org>.
ys4503 commented on issue #13316:
URL: https://github.com/apache/incubator-echarts/issues/13316#issuecomment-730687346
Thanks for sharing your solution. This is a very nice way around and it should be implemented in 'weakFilter' or its own filterMode.
It seems the default mode is intended for performance reasons. However, it should default to your solution in this particular chart type. Using 'none' filterMode also fixes this issue but it doesn't filter any data and it may not be optimum for huge data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org