You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "echooymxq (via GitHub)" <gi...@apache.org> on 2023/08/22 07:43:12 UTC
[GitHub] [rocketmq] echooymxq opened a new pull request, #7220: [ISSUE #7219] Fix Concurrent modify syncStateSet and Mark synchronizi…
echooymxq opened a new pull request, #7220:
URL: https://github.com/apache/rocketmq/pull/7220
…ng frequently when shrink.
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7219
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #7220: [ISSUE #7219] Fix Concurrent modify syncStateSet and Mark synchronizi…
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #7220:
URL: https://github.com/apache/rocketmq/pull/7220#issuecomment-1689092796
@GenerousMan PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #7220: [ISSUE #7219] Fix Concurrent modify syncStateSet and Mark synchronizi…
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7220:
URL: https://github.com/apache/rocketmq/pull/7220#issuecomment-1687684538
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7220?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7220](https://app.codecov.io/gh/apache/rocketmq/pull/7220?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (640ce45) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/72d796f2b20b3ec6aebca8c004d9275d7c749a95?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (72d796f) will **decrease** coverage by `0.03%`.
> Report is 1 commits behind head on develop.
> The diff coverage is `36.36%`.
```diff
@@ Coverage Diff @@
## develop #7220 +/- ##
=============================================
- Coverage 42.46% 42.44% -0.03%
+ Complexity 9353 9339 -14
=============================================
Files 1149 1149
Lines 82111 82112 +1
Branches 10703 10702 -1
=============================================
- Hits 34868 34849 -19
- Misses 42882 42888 +6
- Partials 4361 4375 +14
```
| [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ketmq/store/ha/autoswitch/AutoSwitchHAService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL2F1dG9zd2l0Y2gvQXV0b1N3aXRjaEhBU2VydmljZS5qYXZh) | `51.24% <11.11%> (-0.01%)` | :arrow_down: |
| [...he/rocketmq/broker/controller/ReplicasManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7220?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY29udHJvbGxlci9SZXBsaWNhc01hbmFnZXIuamF2YQ==) | `45.84% <53.84%> (-0.44%)` | :arrow_down: |
... and [26 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7220/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on pull request #7220: [ISSUE #7219] Fix Concurrent modify syncStateSet and Mark synchronizi…
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin commented on PR #7220:
URL: https://github.com/apache/rocketmq/pull/7220#issuecomment-1689090090
LGTM～
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #7220: [ISSUE #7219] Fix Concurrent modify syncStateSet and Mark synchronizi…
Posted by "RongtongJin (via GitHub)" <gi...@apache.org>.
RongtongJin merged PR #7220:
URL: https://github.com/apache/rocketmq/pull/7220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org