[GitHub] [incubator-nuttx-apps] slorquet commented on a diff in pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.

[GitBox <gi...@apache.org>]

slorquet commented on code in PR #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330#discussion_r984294652


##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
 		will mount a FAT FS under /tmp. This is the location where the FAT
 		FS will be mounted.  Default is "/tmp".
 
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT

Review Comment:
   Yes it will. Do you have any idea to avoid that?



##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
 		will mount a FAT FS under /tmp. This is the location where the FAT
 		FS will be mounted.  Default is "/tmp".
 
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
+	bool "Run a sysinit script"
+    default n
+    select NSH_AUTOSCRIPTS
+
+if NSH_RUNSYSINITSCRIPT
+
+config NSH_SYSINITSCRIPT
+	string "Path to sysinit script"
+	default "/etc/init.d/rc.sysinit"
+	---help---
+		This is the path to the sysinit script executed by nsh at boot.
+		The default is init.d/rc.sysinit. This script can be in a ROMFS mounted
+		by NSH or in any other filesystem that was mounted by the board logic.
+
+endif
+
+config NSH_RUNINITSCRIPT
+	bool "Run a startup script"
+    default n

Review Comment:
   My kconfig refused to work with spaces but ok, will do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org