You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by uc...@apache.org on 2015/03/03 16:14:10 UTC
flink git commit: [FLINK-1577] Remove misleading error log when
failing task externally
Repository: flink
Updated Branches:
refs/heads/master dec5e333d -> 9255594fb
[FLINK-1577] Remove misleading error log when failing task externally
Task thread Exceptions were always logged, even if the task was cancelled or
failed externally. In certain scenarios this lead to misleading error messages
and made it hard to figure out the root exception.
When an exception is thrown w/o the task being canceled or failed, the error
is still handled via Task#markFailed(Throwable).
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/9255594f
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/9255594f
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/9255594f
Branch: refs/heads/master
Commit: 9255594fb3b9b7c00d9088c3b630af9ecbdf22f4
Parents: dec5e33
Author: Ufuk Celebi <uc...@apache.org>
Authored: Tue Mar 3 16:06:08 2015 +0100
Committer: Ufuk Celebi <uc...@apache.org>
Committed: Tue Mar 3 16:11:10 2015 +0100
----------------------------------------------------------------------
.../flink/runtime/execution/RuntimeEnvironment.java | 10 ----------
1 file changed, 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/9255594f/flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java b/flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
index 4fa4907..8daee7c 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/execution/RuntimeEnvironment.java
@@ -228,16 +228,6 @@ public class RuntimeEnvironment implements Environment, Runnable {
}
}
catch (Throwable t) {
- String msg;
-
- if(t.getMessage() != null){
- msg = "Error during running invokable: " + t.getMessage();
- } else {
- msg = "Error during running invokable.";
- }
-
- LOG.error(msg, t);
-
if (!owner.isCanceledOrFailed()) {
// Perform clean up when the task failed and has been not canceled by the user
try {