You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Joe Schaefer <jo...@sunstarsys.com> on 2005/09/29 09:20:19 UTC
thaw() isn't a class method
I didn't intend for APR::Request::Cookie::thaw() to be a
class method, but somehow I documented it that way. Any
objections to my applying this patch?
Index: glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm
===================================================================
--- glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm (revision 291369)
+++ glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pm (working copy)
@@ -20,7 +20,6 @@
sub freeze { return $_[1] }
sub thaw {
my $obj = shift;
- return shift if @_;
return "$obj";
}
Index: glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pod
===================================================================
--- glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pod (revision 291369)
+++ glue/perl/xsbuilder/APR/Request/Cookie/Cookie.pod (working copy)
@@ -145,10 +145,10 @@
=head2 thaw
- APR::Request::Cookie->thaw($value)
+ $cookie->thaw()
-Class method that reverses C<< freeze() >>;
-here it returns $value unmodified.
+Reverses C<< freeze() >>; here it simply returns
+$cookie->value since freeze() is a noop.
--
Joe Schaefer
Re: thaw() isn't a class method
Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Thu, 29 Sep 2005, Philip M. Gollucci wrote:
> Joe Schaefer wrote:
>> I didn't intend for APR::Request::Cookie::thaw() to be a class method, but
>> somehow I documented it that way. Any objections to my applying this
>> patch?
> +1
+1
--
best regards,
randy
Re: thaw() isn't a class method
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Joe Schaefer wrote:
> I didn't intend for APR::Request::Cookie::thaw() to be a
> class method, but somehow I documented it that way. Any
> objections to my applying this patch?
+1
--
END
------------------------------------------------------------
What doesn't kill us can only make us stronger.
Nothing is impossible.
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
http://www.liquidityservicesinc.com
http://www.liquidation.com
http://www.uksurplus.com
http://www.govliquidation.com
http://www.gowholesale.com