[GitHub] spark pull request: [SPARK-4733] Add missing prameter comments in ...

[maropu <gi...@git.apache.org>]

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3594#discussion_r21958573
  
    --- Diff: core/src/main/scala/org/apache/spark/Dependency.scala ---
    @@ -60,6 +60,9 @@ abstract class NarrowDependency[T](_rdd: RDD[T]) extends Dependency[T] {
      * @param serializer [[org.apache.spark.serializer.Serializer Serializer]] to use. If set to None,
      *                   the default serializer, as specified by `spark.serializer` config option, will
      *                   be used.
    + * @param keyOrdering key ordering for RDD's shuffles
    + * @param aggregator map-side aggregator for RDD's shuffle
    + * @param mapSideCombine map-side aggregation flag
    --- End diff --
    
    Ok, I'll fix it as follows:
    "@param mapSideCombine whether to perform partial aggregation (also known as map-side combine)"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org