[GitHub] YorkShen closed pull request #1654: [WEEX-651][Android] fix list unable to slide when sticky item has events

[GitBox <gi...@apache.org>]

YorkShen closed pull request #1654: [WEEX-651][Android] fix list unable to slide when sticky item has events
URL: https://github.com/apache/incubator-weex/pull/1654
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/StickyHeaderHelper.java b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/StickyHeaderHelper.java
index 44997bda54..5a12e2e5d9 100644
--- a/android/sdk/src/main/java/com/taobao/weex/ui/component/list/StickyHeaderHelper.java
+++ b/android/sdk/src/main/java/com/taobao/weex/ui/component/list/StickyHeaderHelper.java
@@ -90,7 +90,10 @@ public void notifyStickyShow(WXCell component) {
           existedParent.removeView(headerView);
         }
         headerView.setTag(headComponent.getRef());
-        mParent.addView(headerView);
+        ViewGroup.MarginLayoutParams mlp =
+                new ViewGroup.MarginLayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT,
+                        ViewGroup.LayoutParams.WRAP_CONTENT);
+        mParent.addView(headerView, mlp);
         headerView.setTag(this);
         if(headComponent.getStickyOffset() > 0) {
           ViewGroup.MarginLayoutParams params = (ViewGroup.MarginLayoutParams) headerView.getLayoutParams();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services