You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/07/14 12:31:00 UTC

[jira] [Commented] (HTTPCLIENT-1991) PublicSuffixMatcher invalid behaviour

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884662#comment-16884662 ] 

ASF subversion and git services commented on HTTPCLIENT-1991:
-------------------------------------------------------------

Commit 1afa421f6f4dc2ba29c86cbf1a2c8c83352a60b9 in httpcomponents-client's branch refs/heads/JDK-8212885 from Oleg Kalnichevski
[ https://gitbox.apache.org/repos/asf?p=httpcomponents-client.git;h=1afa421 ]

HTTPCLIENT-1991: incorrect handling of non-standard DNS entries by PublicSuffixMatcher


> PublicSuffixMatcher invalid behaviour
> -------------------------------------
>
>                 Key: HTTPCLIENT-1991
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1991
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.5.8
>            Reporter: cda
>            Assignee: Oleg Kalnichevski
>            Priority: Minor
>             Fix For: 4.5.9, 5.0 Beta5
>
>
> The matches should accept only the suffixes from the list, instead it accepts all one word gibberish.
> Examples:
>  
> From *PublicSuffixMatcher.getDomainRoot* javadocs: _returns *null* if given domain represents a public suffi__x._
> The following should not return null, as it is not a public suffix:
>  
> {code:java}
> publicSuffixMatcher.getDomainRoot( "asd123asd" ) == null
> {code}
>  
>  
> From *PublicSuffixMatcher.matches* javadocs: _Tests whether the given domain matches any of entry from the public suffix list._
> The following text is not a public suffix entry but it returns true:
> {code:java}
> publicSuffixMatcher.matches( "asd123asd" ) == true{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org