You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@commons.apache.org by Gabriele Carcassi <ca...@netbeans.org> on 2004/09/19 21:11:11 UTC

[Digester] [PATCH] SetPropertiesRule ignoreMissingProperty

Hi Robert and Simon,

I finally found some time to work on what we discussed a couple of weeks 
ago. I have extended the SetPropertyRule class to have the 
"ignoreMissingPropery" attribute. It's a boolean that tells the rule whether 
it should fail if it can't find a property to set. The default is true, to 
provide backward compatibility. I have also made sure it works with ignored 
and changed attributes.

I didn't do any work on the BeanUtils package in the end: I couldn't get the 
unit tests to work... both CVS HEAD or latest src release. :-/ I just test 
whether the property is writable. This should work with BeanUtils>=1.6, so I 
didn't put a code check to see whether the correct version was being used.

I created a set of 4 unit tests for the old and the new functionality. All 
the other tests passed. I made the patch the least invasive, couple of 
things can be done more sensibly if you integrate (i.e. the top object could 
be got once on top of the loop).

Anyway, tell me if it's reasonable, or you need me to change something.

Thanks,
Gabriele 


begin 666 SetPropertiesRule-ignoreMissingProperty.patch
M26YD97@Z(%-E=%!R;W!E<G1I97-2=6QE+FIA=F$*/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/0I20U,@9FEL93H@+VAO;64O8W9S<'5B;&EC+VIA:V%R=&$M8V]M
M;6]N<R]D:6=E<W1E<B]S<F,O:F%V82]O<F<O87!A8VAE+V-O;6UO;G,O9&EG
M97-T97(O4V5T4')O<&5R=&EE<U)U;&4N:F%V82QV"G)E=')I979I;F<@<F5V
M:7-I;VX@,2XQ.0ID:69F("UU("UR,2XQ.2!39710<F]P97)T:65S4G5L92YJ
M879A"BTM+2!39710<F]P97)T:65S4G5L92YJ879A"3$P($UA>2 R,# T(# V
M.C,P.C V("TP,# P"3$N,3D**RLK(%-E=%!R;W!E<G1I97-2=6QE+FIA=F$)
M,3D@4V5P(#(P,#0@,3@Z-3,Z,S,@+3 P,# *0$ @+3(R+#8@*S(R+#<@0$ *
M(&EM<&]R="!J879A+G5T:6PN2&%S:$UA<#L*( H@:6UP;W)T(&]R9RYA<&%C
M:&4N8V]M;6]N<RYB96%N=71I;',N0F5A;E5T:6QS.PHK:6UP;W)T(&]R9RYA
M<&%C:&4N8V]M;6]N<RYB96%N=71I;',N4')O<&5R='E5=&EL<SL*(&EM<&]R
M="!O<F<N>&UL+G-A>"Y!='1R:6)U=&5S.PH@"B *0$ @+3$T-"PV("LQ-#4L
M,3(@0$ *(" @(" @*B\@(" @"B @(" @<')I=F%T92!3=')I;F<@6UT@<')O
M<&5R='E.86UE<SL*( HK(" @("\J*@HK(" @(" J(%5S960@=&\@9&5T97)M
M:6YE('=H971H97(@=&AE('!A<G-I;F<@<VAO=6QD(&9A:6P@:68@86X@<')O
M<&5R='D@<W!E8VEF:65D"BL@(" @("H@:6X@=&AE(%A-3"!I<R!M:7-S:6YG
M(&9R;VT@=&AE(&)E86XN($1E9F%U;'0@:7,@=')U92!F;W(@8F%C:W=A<F0@
M8V]M<&%T:6)I;&ET>2X**R @(" @*B\**R @("!P<FEV871E(&)O;VQE86X@
M:6=N;W)E36ES<VEN9U!R;W!E<G1Y(#T@=')U93L**PH@"B @(" @+R\@+2TM
M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM
M+2TM+2TM+2TM(%!U8FQI8R!-971H;V1S"B *0$ @+3$Y-RPV("LR,#0L,3D@
M0$ *(" @(" @(" @(" @(" @(" @(" @(" @(")](%-E='1I;F<@<')O<&5R
M='D@)R(@*R!N86UE("L@(B<@=&\@)R(@*PH@(" @(" @(" @(" @(" @(" @
M(" @(" @=F%L=64@*R B)R(I.PH@(" @(" @(" @(" @?0HK(" @(" @(" @
M(" @"BL@(" @(" @(" @("!I9B H*"%I9VYO<F5-:7-S:6YG4')O<&5R='DI
M("8F("AN86UE("$](&YU;&PI*2!["BL@(" @(" @(" @(" @(" @8F]O;&5A
M;B!T97-T.PHK(" @(" @(" @(" @(" @('1R>2!["BL@(" @(" @(" @(" @
M(" @(" @($]B:F5C="!T;W @/2!D:6=E<W1E<BYP965K*"D["BL@(" @(" @
M(" @(" @(" @(" @('1E<W0@/2 @4')O<&5R='E5=&EL<RYI<U=R:71E86)L
M92AT;W L(&YA;64I.PHK(" @(" @(" @(" @(" @('T@8V%T8V@@*$5X8V5P
M=&EO;B!E*2!["BL@(" @(" @(" @(" @(" @(" @('1H<F]W(&YE=R!2=6YT
M:6UE17AC97!T:6]N*")I9VYO<F5-:7-S:6YG3W!T:6]N<SUF86QS92!N965D
M<R!"96%N571I;" Q+C8@;W(@9W)E871E<B(L(&4I.PHK(" @(" @(" @(" @
M(" @('T**R @(" @(" @(" @(" @("!I9B H(71E<W0I"BL@(" @(" @(" @
M(" @(" @(" @('1H<F]W(&YE=R!.;U-U8VA-971H;V1%>&-E<'1I;VXH(E!R
M;W!E<G1Y("(@*R!N86UE("L@(B!C86XG="!B92!S970B*3L**R @(" @(" @
M(" @('T**R @(" @(" @(" @( H@(" @(" @(" @(" @:68@*&YA;64@(3T@
M;G5L;"D@>PH@(" @(" @(" @(" @(" @('9A;'5E<RYP=70H;F%M92P@=F%L
M=64I.PH@(" @(" @(" @(" @?2 *0$ @+3(V-2PV("LR.#4L,C8@0$ *(" @
M(" @(" @<V(N87!P96YD*")=(BD["B @(" @(" @(')E='5R;B H<V(N=&]3
M=')I;F<H*2D["B **R @("!]"BL**R @(" O*BH**R @(" @*B!)9B!F86QS
M92P@=&AE('!A<G-I;F<@=VEL;"!I;G1E<G)U<'0@=VET:"!A;B!E>&-E<'1I
M;VX@:68@82!P<F]P97)T>0HK(" @(" J('-P96-I9FEE9"!I;B!T:&4@6$U,
M(&ES(&YO="!F;W5N9"X@5&AE(&1E9F%U;'0@:7,@=')U92X**R @(" @*B! 
M<F5T=7)N('1R=64@:68@<VMI<'!I;F<@=&AE('5N;6%T8VAE9"!A='1R:6)U
M=&5S+@HK(" @(" J+PHK(" @('!U8FQI8R!B;V]L96%N(&ES26=N;W)E36ES
M<VEN9U!R;W!E<G1Y*"D@>PHK"BL@(" @(" @(')E='5R;B!T:&ES+FEG;F]R
M94UI<W-I;F=0<F]P97)T>3L**R @("!]"BL**R @(" O*BH**R @(" @*B!)
M9B!S970@=&\@9F%L<V4L('1H92!P87)S:6YG('=I;&P@=&AR;W<@86X@97AC
M97!T:6]N(&EF(&%N('5N;6%T8VAE9 HK(" @(" J(&%T=')I8G5T92!I<R!F
M;W5N9"X@5&AI<R!A;&QO=W,@=&\@=')A<"!M:7-S<&5L;&EN9W,@:6X@=&AE
M(%A-3"!F:6QE+@HK(" @(" J($!P87)A;2!I9VYO<F5-:7-S:6YG4')O<&5R
M='D@9F%L<V4@=&\@<W1O<"!T:&4@<&%R<VEN9R!O;B!U;FUA=&-H960@871T
M<FEB=71E<RX**R @(" @*B\**R @("!P=6)L:6,@=F]I9"!S971)9VYO<F5-
M:7-S:6YG4')O<&5R='DH8F]O;&5A;B!I9VYO<F5-:7-S:6YG4')O<&5R='DI
M('L**PHK(" @(" @("!T:&ES+FEG;F]R94UI<W-I;F=0<F]P97)T>2 ](&EG
@;F]R94UI<W-I;F=0<F]P97)T>3L*(" @("!]"B *( H`
`
end

begin 666 SetPropertiesRuleTestCase.java
M+RH@)$ED.B!39710<F]P97)T:65S4G5L951E<W1#87-E+FIA=F$L=B Q+C<@
M,C P-"\P-2\P-R P,3HR.3HU.2!S:VET8VAI;F<@17AP("0*("H*("H@0V]P
M>7)I9VAT(#(P,#$M,C P-"!4:&4@07!A8VAE(%-O9G1W87)E($9O=6YD871I
M;VXN"B J( H@*B!,:6-E;G-E9"!U;F1E<B!T:&4@07!A8VAE($QI8V5N<V4L
M(%9E<G-I;VX@,BXP("AT:&4@(DQI8V5N<V4B*3L*("H@>6]U(&UA>2!N;W0@
M=7-E('1H:7,@9FEL92!E>&-E<'0@:6X@8V]M<&QI86YC92!W:71H('1H92!,
M:6-E;G-E+@H@*B!9;W4@;6%Y(&]B=&%I;B!A(&-O<'D@;V8@=&AE($QI8V5N
M<V4@870*("H@"B J(" @(" @:'1T<#HO+W=W=RYA<&%C:&4N;W)G+VQI8V5N
M<V5S+TQ)0T5.4T4M,BXP"B J( H@*B!5;FQE<W,@<F5Q=6ER960@8GD@87!P
M;&EC86)L92!L87<@;W(@86=R965D('1O(&EN('=R:71I;F<L('-O9G1W87)E
M"B J(&1I<W1R:6)U=&5D('5N9&5R('1H92!,:6-E;G-E(&ES(&1I<W1R:6)U
M=&5D(&]N(&%N(")!4R!)4R(@0D%325,L"B J(%=)5$A/550@5T%24D%.5$E%
M4R!/4B!#3TY$251)3TY3($]&($%.62!+24Y$+"!E:71H97(@97AP<F5S<R!O
M<B!I;7!L:65D+@H@*B!3964@=&AE($QI8V5N<V4@9F]R('1H92!S<&5C:69I
M8R!L86YG=6%G92!G;W9E<FYI;F<@<&5R;6ES<VEO;G,@86YD"B J(&QI;6ET
M871I;VYS('5N9&5R('1H92!,:6-E;G-E+@H@*B\@"@H*<&%C:V%G92!O<F<N
M87!A8VAE+F-O;6UO;G,N9&EG97-T97(["@H*:6UP;W)T(&IA=F$N:6\N24]%
M>&-E<'1I;VX["FEM<&]R="!J879A+FEO+E)E861E<CL*:6UP;W)T(&IA=F$N
M:6\N4W1R:6YG4F5A9&5R.PII;7!O<G0@:F%V82YL86YG+G)E9FQE8W0N26YV
M;V-A=&EO;E1A<F=E=$5X8V5P=&EO;CL*"FEM<&]R="!J=6YI="YF<F%M97=O
M<FLN5&5S=#L*:6UP;W)T(&IU;FET+F9R86UE=V]R:RY497-T0V%S93L*:6UP
M;W)T(&IU;FET+F9R86UE=V]R:RY497-T4W5I=&4["@II;7!O<G0@;W)G+GAM
M;"YS87@N4T%817AC97!T:6]N.PH*"B\J*@H@*B \<#X@5&5S="!C87-E(&9O
M<B \8V]D93Y39710<F]P97)T:65S4G5L93PO8V]D93XN/"]P/@H@*B\*<'5B
M;&EC(&-L87-S(%-E=%!R;W!E<G1I97-2=6QE5&5S=$-A<V4@97AT96YD<R!4
M97-T0V%S92!["@H*(" @("\O("TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM
M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM($EN<W1A;F-E(%9A<FEA8FQE
M<PH*(" @("\J*@H@(" @("H@4VEM<&QE('1E<W0@>&UL(&1O8W5M96YT('5S
M960@:6X@=&AE('1E<W1S+@H@(" @("HO"B @("!P<F]T96-T960@9FEN86P@
M<W1A=&EC(%-T<FEN9R!415-47UA-3%\Q(#T*(" @(" @(" B/#]X;6P@=F5R
M<VEO;CTG,2XP)S\^/')O;W0@86QP:&$])T%,4$A!(%9!3%5%)R!B971A/2="
M151!(%9!3%5%)R!D96QT83TG1$5,5$$@5D%,544G+SXB.PH*(" @("\J*@H@
M(" @("H@4VEM<&QE('1E<W0@>&UL(&1O8W5M96YT('5S960@:6X@=&AE('1E
M<W1S+@H@(" @("HO"B @("!P<F]T96-T960@9FEN86P@<W1A=&EC(%-T<FEN
M9R!415-47UA-3%\R(#T*(" @(" @(" B/#]X;6P@=F5R<VEO;CTG,2XP)S\^
M/')O;W0@86QP83TG04Q002!604Q512<@8F5T83TG0D5402!604Q512<@9&5L
M=&$])T1%3%1!(%9!3%5%)R\^(CL*"B @(" O*BH*(" @(" J(%-I;7!L92!T
M97-T('AM;"!D;V-U;65N="!U<V5D(&EN('1H92!T97-T<RX*(" @(" J+PH@
M(" @<')O=&5C=&5D(&9I;F%L('-T871I8R!3=')I;F<@5$535%]834Q?,R ]
M"B @(" @(" @(CP_>&UL('9E<G-I;VX])S$N,"<_/CQR;V]T(&%L<&AA/2=!
M3%!(02!604Q512<@8F5T83TG0D5402!604Q512<@9&5L=&$])T1%3%1!(%9!
M3%5%)R!I9VYO<F4])VEG;F]R92!V86QU92<O/B(["@H@(" @+RHJ"B @(" @
M*B!4:&4@9&EG97-T97(@:6YS=&%N8V4@=V4@=VEL;"!B92!P<F]C97-S:6YG
M+@H@(" @("HO"B @("!P<F]T96-T960@1&EG97-T97(@9&EG97-T97(@/2!N
M=6QL.PH*"B @(" O+R M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM
M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2!#;VYS=')U8W1O<G,*"@H@
M(" @+RHJ"B @(" @*B!#;VYS=')U8W0@82!N97<@:6YS=&%N8V4@;V8@=&AI
M<R!T97-T(&-A<V4N"B @(" @*@H@(" @("H@0'!A<F%M(&YA;64@3F%M92!O
M9B!T:&4@=&5S="!C87-E"B @(" @*B\*(" @('!U8FQI8R!39710<F]P97)T
M:65S4G5L951E<W1#87-E*%-T<FEN9R!N86UE*2!["@H@(" @(" @('-U<&5R
M*&YA;64I.PH*(" @('T*"@H@(" @+R\@+2TM+2TM+2TM+2TM+2TM+2TM+2TM
M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM($]V97)A;&P@5&5S="!-
M971H;V1S"@H*(" @("\J*@H@(" @("H@4V5T('5P(&EN<W1A;F-E('9A<FEA
M8FQE<R!R97%U:7)E9"!B>2!T:&ES('1E<W0@8V%S92X*(" @(" J+PH@(" @
M<'5B;&EC('9O:60@<V5T57 H*2!["@H@(" @(" @(&1I9V5S=&5R(#T@;F5W
M($1I9V5S=&5R*"D["@H@(" @?0H*"B @(" O*BH*(" @(" J(%)E='5R;B!T
M:&4@=&5S=',@:6YC;'5D960@:6X@=&AI<R!T97-T('-U:71E+@H@(" @("HO
M"B @("!P=6)L:6,@<W1A=&EC(%1E<W0@<W5I=&4H*2!["@H@(" @(" @(')E
M='5R;B H;F5W(%1E<W13=6ET92A39710<F]P97)T:65S4G5L951E<W1#87-E
M+F-L87-S*2D["@H@(" @?0H*"B @(" O*BH*(" @(" J(%1E87(@9&]W;B!I
M;G-T86YC92!V87)I86)L97,@<F5Q=6ER960@8GD@=&AI<R!T97-T(&-A<V4N
M"B @(" @*B\*(" @('!U8FQI8R!V;VED('1E87)$;W=N*"D@>PH*(" @(" @
M("!D:6=E<W1E<B ](&YU;&P["@H@(" @?0H*"@H@(" @+R\@+2TM+2TM+2TM
M+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM+2TM($EN9&EV
M:61U86P@5&5S="!-971H;V1S"@H*(" @("\J*@H@(" @("H@4&]S:71I=F4@
M=&5S="!F;W(@4V5T4')O<&5R=&EE<U)U;&4N"B @(" @*B\*(" @('!U8FQI
M8R!V;VED('1E<W10;W-I=&EV92@I('1H<F]W<R!%>&-E<'1I;VX@>PH*(" @
M(" @(" O+R!3970@=7 @=&AE(')U;&5S('=E(&YE960*(" @(" @("!D:6=E
M<W1E<BYA9&1/8FIE8W1#<F5A=&4H(G)O;W0B+ H@(" @(" @(" @(" @(" @
M(" @(" @(" @(" @(" @(" B;W)G+F%P86-H92YC;VUM;VYS+F1I9V5S=&5R
M+E-I;7!L951E<W1"96%N(BD["B @(" @(" @9&EG97-T97(N861D4V5T4')O
M<&5R=&EE<R@B<F]O="(I.PH*(" @(" @(" O+R!087)S92!T:&4@:6YP=70*
M(" @(" @("!3:6UP;&5497-T0F5A;B!B96%N(#T*(" @(" @(" @(" @*%-I
M;7!L951E<W1"96%N*2!D:6=E<W1E<BYP87)S92AX;6Q497-T4F5A9&5R*%1%
M4U1?6$U,7S$I*3L*"B @(" @(" @+R\@0VAE8VL@=&AA="!T:&4@<')O<&5R
M=&EE<R!W97)E('-E="!C;W)R96-T;'D*(" @(" @("!A<W-E<G1%<75A;',H
M(F%L<&AA('!R;W!E<G1Y('-E="(L"B @(" @(" @(" @(" @(" @(" @(")!
M3%!(02!604Q512(L"B @(" @(" @(" @(" @(" @(" @(&)E86XN9V5T06QP
M:&$H*2D["B @(" @(" @87-S97)T17%U86QS*")B971A('!R;W!E<G1Y('-E
M="(L"B @(" @(" @(" @(" @(" @(" @(")"151!(%9!3%5%(BP*(" @(" @
M(" @(" @(" @(" @(" @8F5A;BYG971"971A*"DI.PH@(" @(" @(&%S<V5R
M=$YU;&PH(F=A;6UA('!R;W!E<G1Y(&YO="!S970B+ H@(" @(" @(" @(" @
M(" @(" @8F5A;BYG971'86UM82@I*3L*(" @(" @("!A<W-E<G1%<75A;',H
M(F1E;'1A('!R;W!E<G1Y('-E="(L"B @(" @(" @(" @(" @(" @(" @(")$
M14Q402!604Q512(L"B @(" @(" @(" @(" @(" @(" @(&)E86XN9V5T1&5L
M=&%686QU92@I*3L*"B @("!]"@H@(" @+RHJ"B @(" @*B!0;W-I=&EV92!T
M97-T(&9O<B!39710<F]P97)T>5)U;&4@:6=N;W)I;F<@;6ES<VEN9R!P<F]P
M97)T:65S+@H@(" @("HO"B @("!P=6)L:6,@=F]I9"!T97-T26=N;W)E36ES
M<VEN9R@I('1H<F]W<R!%>&-E<'1I;VX@>PH*(" @(" @(" O+R!3970@=7 @
M=&AE(')U;&5S('=E(&YE960*(" @(" @("!D:6=E<W1E<BYA9&1/8FIE8W1#
M<F5A=&4H(G)O;W0B+ H@(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @
M(" B;W)G+F%P86-H92YC;VUM;VYS+F1I9V5S=&5R+E-I;7!L951E<W1"96%N
M(BD["B @(" @(" @9&EG97-T97(N861D4V5T4')O<&5R=&EE<R@B<F]O="(I
M.PH*(" @(" @(" O+R!087)S92!T:&4@:6YP=70*(" @(" @("!3:6UP;&54
M97-T0F5A;B!B96%N(#T*(" @(" @(" @(" @*%-I;7!L951E<W1"96%N*2!D
M:6=E<W1E<BYP87)S92AX;6Q497-T4F5A9&5R*%1%4U1?6$U,7S(I*3L*"B @
M(" @(" @+R\@0VAE8VL@=&AA="!T:&4@<')O<&5R=&EE<R!W97)E('-E="!C
M;W)R96-T;'D*(" @(" @("!A<W-E<G1.=6QL*")A;'!H82!P<F]P97)T>2!N
M;W0@<V5T(BP*(" @(" @(" @(" @(" @(" @(" @8F5A;BYG971!;'!H82@I
M*3L*(" @(" @("!A<W-E<G1%<75A;',H(F)E=&$@<')O<&5R='D@<V5T(BP*
M(" @(" @(" @(" @(" @(" @(" @(D)%5$$@5D%,544B+ H@(" @(" @(" @
M(" @(" @(" @("!B96%N+F=E=$)E=&$H*2D["B @(" @(" @87-S97)T3G5L
M;"@B9V%M;6$@<')O<&5R='D@;F]T('-E="(L"B @(" @(" @(" @(" @(" @
M("!B96%N+F=E=$=A;6UA*"DI.PH@(" @(" @(&%S<V5R=$5Q=6%L<R@B9&5L
M=&$@<')O<&5R='D@<V5T(BP*(" @(" @(" @(" @(" @(" @(" @(D1%3%1!
M(%9!3%5%(BP*(" @(" @(" @(" @(" @(" @(" @8F5A;BYG971$96QT859A
M;'5E*"DI.PH*(" @('T*"B @(" O*BH*(" @(" J($YE9V%T:79E('1E<W0@
M9F]R(%-E=%!R;W!E<G1Y4G5L92!I9VYO<FEN9R!M:7-S:6YG('!R;W!E<G1I
M97,N"B @(" @*B\*(" @('!U8FQI8R!V;VED('1E<W1.96=A=&EV94YO=$EG
M;F]R94UI<W-I;F<H*2!T:')O=W,@17AC97!T:6]N('L*"B @(" @(" @+R\@
M4V5T('5P('1H92!R=6QE<R!W92!N965D"B @(" @(" @9&EG97-T97(N861D
M3V)J96-T0W)E871E*")R;V]T(BP*(" @(" @(" @(" @(" @(" @(" @(" @
M(" @(" @(" @(F]R9RYA<&%C:&4N8V]M;6]N<RYD:6=E<W1E<BY3:6UP;&54
M97-T0F5A;B(I.PH@(" @(" @(%-E=%!R;W!E<G1I97-2=6QE(')U;&4@/2!N
M97<@4V5T4')O<&5R=&EE<U)U;&4H*3L*(" @(" @("!R=6QE+G-E=$EG;F]R
M94UI<W-I;F=0<F]P97)T>2AF86QS92D["B @(" @(" @9&EG97-T97(N861D
M4G5L92@B<F]O="(L(')U;&4I.PH*(" @(" @("!T<GD@>PH@(" @(" @(" @
M(" O+R!087)S92!T:&4@:6YP=70*(" @(" @(" @(" @4VEM<&QE5&5S=$)E
M86X@8F5A;B ]"B @(" @(" @(" @(" @(" H4VEM<&QE5&5S=$)E86XI(&1I
M9V5S=&5R+G!A<G-E*'AM;%1E<W1296%D97(H5$535%]834Q?,BDI.PH@(" @
M(" @(" @("!F86EL*")3:&]U;&0@:&%V92!T:')O=VX@3F]3=6-H365T:&]D
M17AC97!T:6]N(BD["B @(" @(" @?2!C871C:" H17AC97!T:6]N(&4I('L*
M(" @(" @(" @(" @:68@*&4@:6YS=&%N8V5O9B!.;U-U8VA-971H;V1%>&-E
M<'1I;VXI('L*(" @(" @(" @(" @(" @("\O($5X<&5C=&5D.PH@(" @(" @
M(" @("!](&5L<V4@:68@*&4@:6YS=&%N8V5O9B!305A%>&-E<'1I;VXI('L*
M(" @(" @(" @(" @(" @($5X8V5P=&EO;B!E92 ]("@H4T%817AC97!T:6]N
M*2!E*2YG971%>&-E<'1I;VXH*3L*(" @(" @(" @(" @(" @(&EF("AE92 A
M/2!N=6QL*2!["B @(" @(" @(" @(" @(" @(" @:68@*&5E(&EN<W1A;F-E
M;V8@3F]3=6-H365T:&]D17AC97!T:6]N*2!["B @(" @(" @(" @(" @(" @
M(" @(" @(#L@+R\@17AP96-T960@<F5S=6QT"B @(" @(" @(" @(" @(" @
M(" @?2!E;'-E('L*(" @(" @(" @(" @(" @(" @(" @(" @9F%I;"@B4VAO
M=6QD(&AA=F4@=&AR;W=N(%-%+3Y.;U-U8VA-971H;V1%>&-E<'1I;VXL('1H
M<F5W("(@*R!E92D["B @(" @(" @(" @(" @(" @(" @?0H@(" @(" @(" @
M(" @(" @?2!E;'-E('L*(" @(" @(" @(" @(" @(" @("!F86EL*")3:&]U
M;&0@:&%V92!T:')O=VX@3F]3=6-H365T:&]D17AC97!T:6]N+"!T:')E=R B
M("L*(" @(" @(" @(" @(" @(" @(" @(" @(&4N9V5T0VQA<W,H*2YG971.
M86UE*"DI.PH@(" @(" @(" @(" @(" @?0H@(" @(" @(" @("!](&5L<V4@
M>PH@(" @(" @(" @(" @(" @9F%I;"@B4VAO=6QD(&AA=F4@=&AR;W=N($YO
M4W5C:$UE=&AO9$5X8V5P=&EO;BP@=&AR97<@(B K(&4I.PH@(" @(" @(" @
M("!]"B @(" @(" @?0H@(" @?0H*(" @("\J*@H@(" @("H@3F5G871I=F4@
M=&5S="!F;W(@4V5T4')O<&5R='E2=6QE(&EG;F]R:6YG(&UI<W-I;F<@<')O
M<&5R=&EE<RX*(" @(" J+PH@(" @<'5B;&EC('9O:60@=&5S=%!O<VET:79E
M3F]T26=N;W)E36ES<VEN9U=I=&A)9VYO<F5!='1R:6)U=&5S*"D@=&AR;W=S
M($5X8V5P=&EO;B!["@H@(" @(" @("\O(%-E="!U<"!T:&4@<G5L97,@=V4@
M;F5E9 H@(" @(" @(&1I9V5S=&5R+F%D9$]B:F5C=$-R96%T92@B<F]O="(L
M"B @(" @(" @(" @(" @(" @(" @(" @(" @(" @(" @(")O<F<N87!A8VAE
M+F-O;6UO;G,N9&EG97-T97(N4VEM<&QE5&5S=$)E86XB*3L*(" @(" @("!3
M9710<F]P97)T:65S4G5L92!R=6QE(#T@;F5W(%-E=%!R;W!E<G1I97-2=6QE
M*&YE=R!3=')I;F=;72![(FEG;F]R92)]+"!N97<@4W1R:6YG6UT@>WTI.PH@
M(" @(" @(')U;&4N<V5T26=N;W)E36ES<VEN9U!R;W!E<G1Y*&9A;'-E*3L*
M(" @(" @("!D:6=E<W1E<BYA9&12=6QE*")R;V]T(BP@<G5L92D["@H@(" @
M(" @("\O(%!A<G-E('1H92!I;G!U= H@(" @(" @(%-I;7!L951E<W1"96%N
M(&)E86X@/0H@(" @(" @(" @(" H4VEM<&QE5&5S=$)E86XI(&1I9V5S=&5R
M+G!A<G-E*'AM;%1E<W1296%D97(H5$535%]834Q?,RDI.PH@(" @(" @( H@
M(" @(" @("\O($-H96-K('1H870@=&AE('!R;W!E<G1I97,@=V5R92!S970@
M8V]R<F5C=&QY"B @(" @(" @87-S97)T17%U86QS*")A;'!H82!P<F]P97)T
M>2!S970B+ H@(" @(" @(" @(" @(" @(" @(" B04Q02$$@5D%,544B+ H@
M(" @(" @(" @(" @(" @(" @("!B96%N+F=E=$%L<&AA*"DI.PH@(" @(" @
M(&%S<V5R=$5Q=6%L<R@B8F5T82!P<F]P97)T>2!S970B+ H@(" @(" @(" @
M(" @(" @(" @(" B0D5402!604Q512(L"B @(" @(" @(" @(" @(" @(" @
M(&)E86XN9V5T0F5T82@I*3L*(" @(" @("!A<W-E<G1.=6QL*")G86UM82!P
M<F]P97)T>2!N;W0@<V5T(BP*(" @(" @(" @(" @(" @(" @(&)E86XN9V5T
M1V%M;6$H*2D["B @(" @(" @87-S97)T17%U86QS*")D96QT82!P<F]P97)T
M>2!S970B+ H@(" @(" @(" @(" @(" @(" @(" B1$5,5$$@5D%,544B+ H@
M(" @(" @(" @(" @(" @(" @("!B96%N+F=E=$1E;'1A5F%L=64H*2D["B @
M("!]"@H*(" @("\J*@H@(" @("H@1V5T(&EN<'5T('-T<F5A;2!F<F]M('-P
M96-I9FEE9"!3=')I;F<@8V]N=&%I;FEN9R!834P@9&%T82X*(" @(" J+PH@
M(" @<')I=F%T92!296%D97(@>&UL5&5S=%)E861E<BA3=')I;F<@>&UL*2!T
M:')O=W,@24]%>&-E<'1I;VX@>PH@(" @(" @(')E='5R;B!N97<@4W1R:6YG
84F5A9&5R*'AM;"D["B @("!]"@I]"@H*
`
end



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [Digester] [PATCH] SetPropertiesRule ignoreMissingProperty

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
committed

- robert

On 21 Sep 2004, at 20:33, Gabriele Carcassi wrote:

>> submit a patch :)
> Eh, eh, eh... You got me confused for a moment. :-)
>
> Thanks!
> Gabriele
>
> "robert burrell donkin" <ro...@blueyonder.co.uk> wrote in
> message news:4F7744EB-0BFF-11D9-A9FC-003065DC754C@blueyonder.co.uk...
>> On 21 Sep 2004, at 19:39, Gabriele Carcassi wrote:
>>
>>> Hi Robert,
>>
>> <snip>
>>
>>> Another thing: do I get to be in the list of contributors? :-)
>>
>> submit a patch :)
>>
>> - robert
>
>
> <contributor.patch>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [Digester] [PATCH] SetPropertiesRule ignoreMissingProperty

Posted by Gabriele Carcassi <ca...@netbeans.org>.
> submit a patch :)
Eh, eh, eh... You got me confused for a moment. :-)

Thanks!
Gabriele

"robert burrell donkin" <ro...@blueyonder.co.uk> wrote in 
message news:4F7744EB-0BFF-11D9-A9FC-003065DC754C@blueyonder.co.uk...
> On 21 Sep 2004, at 19:39, Gabriele Carcassi wrote:
>
>> Hi Robert,
>
> <snip>
>
>> Another thing: do I get to be in the list of contributors? :-)
>
> submit a patch :)
>
> - robert 


begin 666 contributor.patch
M26YD97@Z('!R;VIE8W0N>&UL"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T*4D-3
M(&9I;&4Z("]H;VUE+V-V<W!U8FQI8R]J86MA<G1A+6-O;6UO;G,O9&EG97-T
M97(O<')O:F5C="YX;6PL=@IR971R:65V:6YG(')E=FES:6]N(#$N,C,*9&EF
M9B M=2 M<C$N,C,@<')O:F5C="YX;6P*+2TM('!R;VIE8W0N>&UL"3$Y(%-E
M<" R,# T(#$V.C4Q.C$X("TP,# P"3$N,C,**RLK('!R;VIE8W0N>&UL"3(Q
M(%-E<" R,# T(#$Y.C(U.C,X("TP,# P"D! ("TQ.#@L-B K,3@X+#D@0$ *
M(" @(" \8V]N=')I8G5T;W(^"B @(" @(" \;F%M93Y-871T($-L979E;&%N
M9#PO;F%M93X*(" @(" \+V-O;G1R:6)U=&]R/@HK(" @(#QC;VYT<FEB=71O
M<CX**R @(" @(#QN86UE/D=A8G)I96QE($-A<F-A<W-I/"]N86UE/@HK(" @
M(#PO8V]N=')I8G5T;W(^"B @(#PO8V]N=')I8G5T;W)S/@H@(" *(" @/&1E
,<&5N9&5N8VEE<SX*
`
end



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [Digester] [PATCH] SetPropertiesRule ignoreMissingProperty

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 21 Sep 2004, at 19:39, Gabriele Carcassi wrote:

> Hi Robert,

<snip>

> Another thing: do I get to be in the list of contributors? :-)

submit a patch :)

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [Digester] [PATCH] SetPropertiesRule ignoreMissingProperty

Posted by Gabriele Carcassi <ca...@netbeans.org>.
Hi Robert,

> BTW beanutils compiles fine for me and all the tests run. i haven't 
> noticed any gump nags so i'd say that it's most likely something in your 
> configuration. beanutils uses maven only for reporting so you need to use 
> the ant build.
Duh! I didn't think about using ant... and I do have project in which I use 
maven just for reporting. Oh well... It's less invasive like this anyway.

> i made a few minor adjustments. i'm a little reluctant to throw runtimes 
> from a deep library (such as digester) since they may produce nasty 
> effects for components higher up the food chain.
I imagine... There is no need for it at this point: it was there because I 
didn't really know what to do with the BeanUtils>=1.6 dependency. It would 
have changed to an introspection test in case we really needed to check the 
version.

Another thing: do I get to be in the list of contributors? :-)

Gabriele 




---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [Digester] [PATCH] SetPropertiesRule ignoreMissingProperty

Posted by robert burrell donkin <ro...@blueyonder.co.uk>.
On 19 Sep 2004, at 20:11, Gabriele Carcassi wrote:

> Hi Robert and Simon,

hi Gabriele

committed. many thanks.

> I finally found some time to work on what we discussed a couple of 
> weeks
> ago. I have extended the SetPropertyRule class to have the
> "ignoreMissingPropery" attribute. It's a boolean that tells the rule 
> whether
> it should fail if it can't find a property to set. The default is 
> true, to
> provide backward compatibility. I have also made sure it works with 
> ignored
> and changed attributes.

good

> I didn't do any work on the BeanUtils package in the end: I couldn't 
> get the
> unit tests to work... both CVS HEAD or latest src release. :-/ I just 
> test
> whether the property is writable. This should work with 
> BeanUtils>=1.6, so I
> didn't put a code check to see whether the correct version was being 
> used.

that sounds pretty reasonable. the maven descriptor has 1.6 as the 
required dependency so no change is needed there.

BTW beanutils compiles fine for me and all the tests run. i haven't 
noticed any gump nags so i'd say that it's most likely something in 
your configuration. beanutils uses maven only for reporting so you need 
to use the ant build.

> I created a set of 4 unit tests for the old and the new functionality. 
> All
> the other tests passed. I made the patch the least invasive, couple of
> things can be done more sensibly if you integrate (i.e. the top object 
> could
> be got once on top of the loop).

looks good :)

i made a few minor adjustments. i'm a little reluctant to throw 
runtimes from a deep library (such as digester) since they may produce 
nasty effects for components higher up the food chain. i don't see why 
we particularly need to catch an exception at that stage. if someone 
can come up with a good reason why we need to catch exceptions at that 
point, we could consider changing this later.

- robert


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org