[PR] fix: nanos_to_hours returning incorrect hour values [iceberg-python]

["geruh (via GitHub)" <gi...@apache.org>]

geruh opened a new pull request, #2920:
URL: https://github.com/apache/iceberg-python/pull/2920

   # Rationale for this change
   This PR removes an extra 0 from the nanos_to_hours conversion method which resulted in incorrect partitioning. Found this while testing out the V3 `TimestampNanoType` and partitioning. 
   
   ## Are these changes tested?
   Yes, I added some tests from the java side to ensure we align.
   
   - https://github.com/apache/iceberg/blob/9b573c7b46950a41d614c4240752f255282d8c1f/api/src/test/java/org/apache/iceberg/util/TestDateTimeUtil.java#L70
   
   ## Are there any user-facing changes?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

Re: [PR] fix: nanos_to_hours returning incorrect hour values [iceberg-python]

["kevinjqliu (via GitHub)" <gi...@apache.org>]

kevinjqliu merged PR #2920:
URL: https://github.com/apache/iceberg-python/pull/2920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org