You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/13 05:14:39 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7585: Fix warning reported by https://github.com/apache/incubator-nuttx/pull/7391
xiaoxiang781216 opened a new pull request, #7585:
URL: https://github.com/apache/incubator-nuttx/pull/7585
## Summary
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7585: Fix warning reported by https://github.com/apache/incubator-nuttx/pull/7391
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7585:
URL: https://github.com/apache/incubator-nuttx/pull/7585#discussion_r1020847140
##########
arch/arm/src/rp2040/rp2040_cyw43439.c:
##########
@@ -841,7 +841,7 @@ gspi_dev_t *rp2040_cyw_setup(uint8_t gpio_on,
return NULL;
}
- wlinfo("setup complete. gspi = 0x%08lX\n", (uint32_t) gspi);
+ wlinfo("setup complete. gspi = 0x%08p\n", gspi);
return (void *)gspi;
Review Comment:
```suggestion
return gspi;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7585: Fix warning reported by clang
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7585:
URL: https://github.com/apache/incubator-nuttx/pull/7585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7585: Fix warning reported by https://github.com/apache/incubator-nuttx/pull/7391
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7585:
URL: https://github.com/apache/incubator-nuttx/pull/7585#discussion_r1020855815
##########
arch/arm/src/rp2040/rp2040_cyw43439.c:
##########
@@ -841,7 +841,7 @@ gspi_dev_t *rp2040_cyw_setup(uint8_t gpio_on,
return NULL;
}
- wlinfo("setup complete. gspi = 0x%08lX\n", (uint32_t) gspi);
+ wlinfo("setup complete. gspi = 0x%08p\n", gspi);
return (void *)gspi;
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org