You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Sergey Beryozkin (JIRA)" <ji...@apache.org> on 2012/06/27 19:25:43 UTC
[jira] [Created] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Sergey Beryozkin created CAMEL-5405:
---------------------------------------
Summary: CXF Transport loses HTTP Matrix parameters
Key: CAMEL-5405
URL: https://issues.apache.org/jira/browse/CAMEL-5405
Project: Camel
Issue Type: Bug
Components: camel-cxf
Affects Versions: 2.9.2
Reporter: Sergey Beryozkin
Fix For: 2.9.3, 2.10.0
DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin reopened CAMEL-5405:
-------------------------------------
Estimated Complexity: Novice (was: Unknown)
Propagating the actual Request URI causes the mis-match at the CXF level when Camel Servlet is also used. For example, Camel Servlet will set Request URI as "/webapp/HelloWorld", but also set the base URI as "servlet:///HelloWorld".
To calculate the base address, CXF needs HttpServletRequest propagated too
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang updated CAMEL-5405:
--------------------------------
Fix Version/s: (was: 2.10.0)
2.10.1
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-5405.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.8.6
Applied patch into trunk, 2.9.x and 2.8.x branch with thanks to Sergey.
I also added ASL header for the test file.
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.0
>
> Attachments: camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-5405.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.9.3
2.10.1
2.11.0
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.11.0, 2.10.1, 2.9.3
>
> Attachments: camel5405_2.diff, camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431132#comment-13431132 ]
Willem Jiang commented on CAMEL-5405:
-------------------------------------
@Sergey,
I just applied the patch into the trunk, it could be great if you can provide an integration test to show the whole story :).
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff, camel5405_2.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431658#comment-13431658 ]
Willem Jiang commented on CAMEL-5405:
-------------------------------------
Hi Sergey,
I will keep this issue open until we get the integration test committed :).
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff, camel5405_2.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464642#comment-13464642 ]
Sergey Beryozkin commented on CAMEL-5405:
-----------------------------------------
I'll get the test done asap, still committed to it; I'm not sure it is needed though for this issue, propagating HTTP Servlet references is needed for some of our demos to work but it is useful irrespectively of that; please feel free to close this issue.
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Attachments: camel5405_2.diff, camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431650#comment-13431650 ]
Sergey Beryozkin commented on CAMEL-5405:
-----------------------------------------
Hi Willem - thanks for applying it. This will fix one of our failing demos.
I can promise here I'll take an action and work on creating an integration test. It may take a bit of time - I'm mostly offline till the end of next week, but I'll get it done.
Cheers
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff, camel5405_2.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin updated CAMEL-5405:
------------------------------------
Attachment: camel5405.diff
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Fix For: 2.9.3, 2.10.0
>
> Attachments: camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464634#comment-13464634 ]
Claus Ibsen commented on CAMEL-5405:
------------------------------------
Any update on this. If a new test is needed then create a new ticket as we need this ticket to be in the changelog for upcoming releases.
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Attachments: camel5405_2.diff, camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-5405:
-----------------------------------
Assignee: Willem Jiang
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.9.3, 2.10.0
>
> Attachments: camel5405.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431651#comment-13431651 ]
Sergey Beryozkin commented on CAMEL-5405:
-----------------------------------------
Btw, propagating servlet request/response will also make sure that they can be injected as JAX-RS Context objects or accessed as JAX-WS properties, so the fix is good :-)
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff, camel5405_2.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5405) CXF Transport loses HTTP Matrix
parameters
Posted by "Sergey Beryozkin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Beryozkin updated CAMEL-5405:
------------------------------------
Attachment: camel5405_2.diff
HttpServletRequest and HttpServletResponse are also propagated, without introducing CXF HTTP Transport or Servlet API dependencies
> CXF Transport loses HTTP Matrix parameters
> ------------------------------------------
>
> Key: CAMEL-5405
> URL: https://issues.apache.org/jira/browse/CAMEL-5405
> Project: Camel
> Issue Type: Bug
> Components: camel-cxf
> Affects Versions: 2.9.2
> Reporter: Sergey Beryozkin
> Assignee: Willem Jiang
> Fix For: 2.8.6, 2.9.3, 2.10.1
>
> Attachments: camel5405.diff, camel5405_2.diff
>
>
> DefaultCxfMesssageMapper (note the typo - to be fixed in a follow-up JIRA) wrongly initializes CXF Message Message.REQUEST_URI property with the value of Camel Exchange.HTTP_PATH, even though Camel Exchange.HTTP_URI is available.
> The net effect is that the HTTP matrix parameters if any attached to the last HTTP path segment are lost. Another side-effect is that Exchange.HTTP_PATH will contain the decoded value (done at HTTPServletRequest level) which can lead to the matching issues at the JAX-RS level.
> A simple patch is attached
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira