You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2024/07/10 03:36:12 UTC
[PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
kaijchen opened a new pull request, #37577:
URL: https://github.com/apache/doris/pull/37577
cherry-pick #34897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219484925
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219508305
<details>
<summary>TPC-H: <b>Total hot run time: 49854 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e1e964488ad135cd7bf87fb6da610652a1ca94ea, data reload: false
------ Round 1 ----------------------------------
q1 17915 4341 4292 4292
q2 2058 152 155 152
q3 10271 1904 1883 1883
q4 10346 1253 1316 1253
q5 8753 3873 3933 3873
q6 228 145 125 125
q7 2064 1585 1623 1585
q8 9296 2734 2698 2698
q9 10613 10344 10335 10335
q10 8689 3535 3498 3498
q11 415 245 251 245
q12 473 307 304 304
q13 18358 3969 4039 3969
q14 358 319 336 319
q15 501 461 456 456
q16 679 576 583 576
q17 1138 939 945 939
q18 7217 6841 6906 6841
q19 1776 1670 1629 1629
q20 562 303 314 303
q21 4378 4155 4137 4137
q22 530 442 450 442
Total cold run time: 116618 ms
Total hot run time: 49854 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4332 4276 4371 4276
q2 322 231 225 225
q3 4157 4133 4133 4133
q4 2734 2734 2739 2734
q5 7207 7098 7125 7098
q6 233 119 119 119
q7 3263 2854 2854 2854
q8 4377 4475 4490 4475
q9 16898 16755 16799 16755
q10 4249 4254 4302 4254
q11 750 681 701 681
q12 1024 882 870 870
q13 7172 3769 3715 3715
q14 448 428 420 420
q15 495 457 456 456
q16 739 671 688 671
q17 3848 3818 3858 3818
q18 8817 8786 8854 8786
q19 1722 1723 1663 1663
q20 2349 2096 2114 2096
q21 8513 8503 8390 8390
q22 1018 983 980 980
Total cold run time: 84667 ms
Total hot run time: 79469 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219527583
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit e1e964488ad135cd7bf87fb6da610652a1ca94ea with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 21.6 seconds inserted 10000000 Rows, about 462K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219524673
<details>
<summary>ClickBench: <b>Total hot run time: 30.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e1e964488ad135cd7bf87fb6da610652a1ca94ea, data reload: false
query1 0.02 0.02 0.02
query2 0.06 0.03 0.02
query3 0.25 0.06 0.05
query4 1.78 0.07 0.07
query5 0.54 0.52 0.53
query6 1.24 0.61 0.68
query7 0.01 0.02 0.02
query8 0.03 0.02 0.03
query9 0.52 0.48 0.48
query10 0.53 0.53 0.55
query11 0.12 0.08 0.08
query12 0.11 0.09 0.09
query13 0.63 0.61 0.61
query14 0.78 0.81 0.79
query15 0.78 0.77 0.76
query16 0.37 0.36 0.36
query17 1.02 0.99 0.97
query18 0.22 0.26 0.24
query19 1.91 1.88 1.84
query20 0.01 0.01 0.01
query21 15.47 0.56 0.54
query22 2.36 2.45 1.72
query23 16.85 0.90 0.98
query24 4.66 1.67 1.31
query25 0.39 0.12 0.04
query26 0.59 0.16 0.16
query27 0.04 0.04 0.04
query28 7.60 0.77 0.72
query29 12.70 2.24 2.10
query30 0.57 0.52 0.57
query31 2.80 0.40 0.37
query32 3.35 0.50 0.50
query33 3.07 3.07 3.12
query34 15.25 4.79 4.78
query35 4.89 4.87 4.86
query36 1.03 1.01 1.02
query37 0.06 0.05 0.04
query38 0.03 0.02 0.02
query39 0.01 0.01 0.02
query40 0.16 0.14 0.14
query41 0.07 0.02 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 102.92 s
Total hot run time: 30.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #37577:
URL: https://github.com/apache/doris/pull/37577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219479759
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219479713
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219505676
TeamCity be ut coverage result:
Function Coverage: 37.88% (8113/21419)
Line Coverage: 29.55% (66489/224997)
Region Coverage: 29.01% (34261/118084)
Branch Coverage: 24.89% (17598/70716)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e1e964488ad135cd7bf87fb6da610652a1ca94ea_e1e964488ad135cd7bf87fb6da610652a1ca94ea/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](load) skip sending cancel rpc if VNodeChannel is not inited (#34897) [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37577:
URL: https://github.com/apache/doris/pull/37577#issuecomment-2219519937
<details>
<summary>TPC-DS: <b>Total hot run time: 203326 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e1e964488ad135cd7bf87fb6da610652a1ca94ea, data reload: false
query1 951 416 381 381
query2 6537 2842 2750 2750
query3 6915 210 195 195
query4 21284 18063 18093 18063
query5 19740 6491 6554 6491
query6 289 220 224 220
query7 4158 306 317 306
query8 425 465 421 421
query9 3109 2655 2581 2581
query10 416 307 302 302
query11 11330 10711 10653 10653
query12 122 74 74 74
query13 5608 699 708 699
query14 17361 13765 13437 13437
query15 360 255 241 241
query16 6469 285 258 258
query17 1712 1438 886 886
query18 2317 410 405 405
query19 214 151 152 151
query20 76 79 77 77
query21 194 97 92 92
query22 5234 4967 5007 4967
query23 32399 31952 31922 31922
query24 6967 6547 6575 6547
query25 525 431 442 431
query26 512 163 158 158
query27 1762 302 298 298
query28 6121 2341 2297 2297
query29 2995 2768 2825 2768
query30 244 168 168 168
query31 900 732 775 732
query32 66 65 62 62
query33 405 258 252 252
query34 836 472 480 472
query35 1132 945 932 932
query36 1251 1102 1096 1096
query37 89 59 59 59
query38 3121 2927 2964 2927
query39 1392 1313 1328 1313
query40 208 97 93 93
query41 47 45 44 44
query42 87 84 82 82
query43 706 632 670 632
query44 1190 731 723 723
query45 252 245 237 237
query46 1261 986 996 986
query47 1756 1765 1758 1758
query48 1023 707 707 707
query49 621 373 385 373
query50 859 617 626 617
query51 4750 4643 4700 4643
query52 97 76 94 76
query53 452 324 321 321
query54 2689 2486 2468 2468
query55 83 80 76 76
query56 236 227 215 215
query57 1091 1040 1092 1040
query58 221 210 197 197
query59 4130 3919 4087 3919
query60 212 209 218 209
query61 97 97 96 96
query62 815 464 466 464
query63 488 354 346 346
query64 2508 1563 1472 1472
query65 3617 3562 3546 3546
query66 770 377 378 377
query67 16416 14997 15448 14997
query68 9376 660 648 648
query69 586 361 347 347
query70 1589 1447 1220 1220
query71 418 314 317 314
query72 6565 3478 3491 3478
query73 739 315 323 315
query74 6257 5939 5926 5926
query75 5449 3722 3633 3633
query76 5822 1180 1164 1164
query77 977 265 258 258
query78 12476 11940 11599 11599
query79 7209 642 642 642
query80 1196 412 394 394
query81 496 240 234 234
query82 1440 98 95 95
query83 192 135 132 132
query84 264 73 72 72
query85 876 329 328 328
query86 344 288 313 288
query87 3265 3051 3053 3051
query88 4546 2317 2329 2317
query89 373 276 281 276
query90 1976 199 187 187
query91 170 134 138 134
query92 60 58 53 53
query93 5650 582 614 582
query94 706 212 211 211
query95 1102 1071 1043 1043
query96 646 328 326 326
query97 6517 6369 6281 6281
query98 196 184 181 181
query99 2907 1004 799 799
Total cold run time: 312605 ms
Total hot run time: 203326 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org