You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/03/01 17:54:16 UTC
[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6201
Change subject: KUDU-1904 Don't seek on empty RLE blocks
......................................................................
KUDU-1904 Don't seek on empty RLE blocks
Seeking in RLE blocks enforces that the seek position is less than
the number of elements in the block. If the number of elements is 0,
as it is when the entire set of cells is NULL, this check will always
result in a crash.
This patch enforces that the block only seeks if there are elements
in the block.
Test coverage will be added in an upcoming commit.
Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Reviewed-on: http://gerrit.cloudera.org:8080/6184
Reviewed-by: David Ribeiro Alves <dr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit 79706b0ab3e746f94519a1b49c8960c3c75fd36d)
---
M src/kudu/cfile/rle_block.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6201/1
--
To view, visit http://gerrit.cloudera.org:8080/6201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1904 Don't seek on empty RLE blocks
......................................................................
Patch Set 2: Code-Review+2 Verified+1
Test failure isn't related, although it's an odd one.
--
To view, visit http://gerrit.cloudera.org:8080/6201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has uploaded a new patch set (#2).
Change subject: KUDU-1904 Don't seek on empty RLE blocks
......................................................................
KUDU-1904 Don't seek on empty RLE blocks
Seeking in RLE blocks enforces that the seek position is less than
the number of elements in the block. If the number of elements is 0,
as it is when the entire set of cells is NULL, this check will always
result in a crash.
This patch enforces that the block only seeks if there are elements
in the block.
Test coverage will be added in an upcoming commit.
Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
---
M src/kudu/cfile/rle_block.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/6201/2
--
To view, visit http://gerrit.cloudera.org:8080/6201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.2.x) KUDU-1904 Don't seek on empty RLE blocks
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1904 Don't seek on empty RLE blocks
......................................................................
KUDU-1904 Don't seek on empty RLE blocks
Seeking in RLE blocks enforces that the seek position is less than
the number of elements in the block. If the number of elements is 0,
as it is when the entire set of cells is NULL, this check will always
result in a crash.
This patch enforces that the block only seeks if there are elements
in the block.
Test coverage will be added in an upcoming commit.
Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Reviewed-on: http://gerrit.cloudera.org:8080/6201
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/cfile/rle_block.h
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6201
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>