[GitHub] [superset] villebro commented on pull request #16396: fix: add percent sign in like/ilike clause

[GitBox <gi...@apache.org>]

villebro commented on pull request #16396:
URL: https://github.com/apache/superset/pull/16396#issuecomment-920672125


   I'm leaning in the direction of adding three new operators for more business-like users. I'd propose the following:
   - keep the current `LIKE` and `LIKE (case insensitive)` operators as they are now. The target audience for these are mainly power users who want to write their own SQL based LIKE filters (let's not forget the `_` single character wildcard effect which is also supported in `LIKE`). Keeping these unchanged would also ensure we don't do a breaking change.
   - Add new operators: "Contains", "Starts with" and "Ends with" (`'%str%'`, `'str%'` and `'%str'` respectively) that will escape underscores, do **case insensitive** matching when writing all lowercase (e.g. "ma") and **case sensitive** when writing mixed case (e.g. "Ma"). These would be primarily geared towards less technical business users. The reason for deciding when to do case sensitive vs insensitive matching is to keep the basic UX as simple as possible and avoid having to add separate case sensitive and insensitive variants of these operators.
   
   Someone will undoubtedly want to do case sensitive all lowercase matching, but for those cases they should probably just learn to use the full `LIKE` operator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org