[GitHub] [bookkeeper] mauricebarnum commented on a change in pull request #3067: Recover only those entries which as supposed to be on dead bookie

[GitBox <gi...@apache.org>]

mauricebarnum commented on a change in pull request #3067:
URL: https://github.com/apache/bookkeeper/pull/3067#discussion_r810671246



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerFragmentReplicator.java
##########
@@ -133,6 +133,16 @@ public LedgerFragmentReplicator(BookKeeper bkc, ClientConfiguration conf) {
     private static final Logger LOG = LoggerFactory
             .getLogger(LedgerFragmentReplicator.class);
 
+    private boolean isEntryExpectedOnDeadBookie(final LedgerHandle lh, Long eId, Set<Integer> deadBookieIndex) {

Review comment:
       looks like this would work and might be the shortest path from where you are to where you want to get.
   
   it's somewhat unfortunate you can't just configure the LedgerHandle to avoid the dead bookies when creating the write set.  there's almost support in there for doing that, but it isn't too flexible and ultimately optional at both the LedgerHandle and DistributionSchedule implementation levels.  see how bookie health info is almost useful.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org