You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/12/16 17:23:30 UTC
[GitHub] [openwhisk-runtime-dotnet] rabbah opened a new pull request #44: Export init args to environment.
rabbah opened a new pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44
Closes #43.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #44: Export init args to environment.
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44#discussion_r544707932
##########
File path: core/dotnet3.1/proxy/Apache.OpenWhisk.Runtime.Common/Init.cs
##########
@@ -120,6 +121,17 @@ public async Task<Run> HandleRequest(HttpContext httpContext)
try
{
+ // Export init arguments as environment variables
+ if (message["env"] != null && message["env"].HasValues)
Review comment:
@shawnallen85 this is to avoid null exceptions when the env is a "null" json value.
I opted to put the code here instead of earlier to let the quicker failures to come first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-dotnet] shawnallen85 merged pull request #44: Export init args to environment.
Posted by GitBox <gi...@apache.org>.
shawnallen85 merged pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull request #44: Export init args to environment.
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44#discussion_r551028350
##########
File path: core/dotnet3.1/proxy/Apache.OpenWhisk.Runtime.Common/Init.cs
##########
@@ -120,6 +121,17 @@ public async Task<Run> HandleRequest(HttpContext httpContext)
try
{
+ // Export init arguments as environment variables
+ if (message["env"] != null && message["env"].HasValues)
Review comment:
I didn't do it because of your note to the dev list to deprecate .NET 2.2.
Can add it to the PR if you think it's a good idea. I defer to your judgement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-dotnet] shawnallen85 commented on a change in pull request #44: Export init args to environment.
Posted by GitBox <gi...@apache.org>.
shawnallen85 commented on a change in pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44#discussion_r550959605
##########
File path: core/dotnet3.1/proxy/Apache.OpenWhisk.Runtime.Common/Init.cs
##########
@@ -120,6 +121,17 @@ public async Task<Run> HandleRequest(HttpContext httpContext)
try
{
+ // Export init arguments as environment variables
+ if (message["env"] != null && message["env"].HasValues)
Review comment:
Sorry for the delay.
The code change looks good to me. Would it make sense to add it to the .NET Core 2.2 runtime as well?
Thanks!!
Shawn
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-dotnet] shawnallen85 commented on a change in pull request #44: Export init args to environment.
Posted by GitBox <gi...@apache.org>.
shawnallen85 commented on a change in pull request #44:
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/44#discussion_r551030542
##########
File path: core/dotnet3.1/proxy/Apache.OpenWhisk.Runtime.Common/Init.cs
##########
@@ -120,6 +121,17 @@ public async Task<Run> HandleRequest(HttpContext httpContext)
try
{
+ // Export init arguments as environment variables
+ if (message["env"] != null && message["env"].HasValues)
Review comment:
I figured that was the case but I wanted to make sure. I think it would be fine to keep .NET 2.2 as-is and move forward with making the change only in the 3.1 version of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org