[jira] [Commented] (NIFI-4328) Invalid swagger.json generated from ControllerServiceReferencingComponentDTO#referencingCompoents

["Matt Gilman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184281#comment-16184281 ] 

Matt Gilman commented on NIFI-4328:
-----------------------------------

It appears that upgrading to the latest version of swagger addresses the issues with the recursive models. Will file a PR for this soon.

> Invalid swagger.json generated from ControllerServiceReferencingComponentDTO#referencingCompoents
> -------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4328
>                 URL: https://issues.apache.org/jira/browse/NIFI-4328
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.3.0, 1.4.0
>            Reporter: Michael Werle
>            Assignee: Matt Gilman
>
> The referencingComponents field in {{nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ControllerServiceReferencingComponentDTO.java}} field generates the following lines in swagger.json:
> {code:javascript}
>     "ControllerServiceReferencingComponentDTO" : {
>       "properties" : {
>         //... (omitted for brevity)
>         "referencingComponents" : {
>           "description" : "If the referencing component represents a controller service, these are the components that reference it.",
>           "$ref" : "#/definitions/Set"
>         }
>       }
>     }
> {code}
> Which causes this invalid object definition:
> {code:javascript}
>     "Set" : {
>       "properties" : {
>         "empty" : {
>           "type" : "boolean",
>           "default" : false
>         }
>       }
>     }
> {code}
> It is not clear how to fix the annotation, but the generated swagger.json should be:
> {code:javascript}
>     "ControllerServiceReferencingComponentDTO" : {
>       "properties" : {
>         //... (omitted for brevity)
>         "referencingComponents" : {
>           "type" : "array",
>           "description" : "If the referencing component represents a controller service, these are the components that reference it.",
>           "uniqueItems" : true,
>           "items" : {
>             "$ref" : "#/definitions/ControllerServiceReferencingComponentEntity"
>           }
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)