You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/10/07 03:46:01 UTC

[GitHub] [hadoop] bshashikant commented on issue #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used

bshashikant commented on issue #1596: HDDS-2233 - Remove ByteStringHelper and refactor the code to the place where it used
URL: https://github.com/apache/hadoop/pull/1596#issuecomment-538829264
 
 
   Thanks @fapifta for working on this. In addition to Mukul's comments, I feel ByteBuffer to byteString conversion should be a general utility function and should not take configuration object as dependency to determine safe or unsafe copy. Let's pass the boolean flag instead as it would be more friendly to use where ever needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org