[GitHub] [arrow] sanjibansg commented on a diff in pull request #13390: ARROW-16424: [C++] Update uri_path parsing in FromProto

[GitBox <gi...@apache.org>]

sanjibansg commented on code in PR #13390:
URL: https://github.com/apache/arrow/pull/13390#discussion_r909226803


##########
cpp/src/arrow/engine/substrait/relation_internal.h:
##########
@@ -24,6 +24,7 @@
 #include "arrow/engine/substrait/serde.h"
 #include "arrow/engine/substrait/visibility.h"
 #include "arrow/type_fwd.h"
+#include "arrow/util/uri.h"

Review Comment:
   made the change, thanks!



##########
cpp/src/arrow/util/uri.h:
##########
@@ -68,6 +68,8 @@ class ARROW_EXPORT Uri {
   /// The URI path component.
   std::string path() const;
 
+  std::string extension() const;

Review Comment:
   added docstring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org