You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/06 19:46:05 UTC
[GitHub] [thrift] pprice opened a new pull request #1855: Fix a number of js/ts generation issues
pprice opened a new pull request #1855:
URL: https://github.com/apache/thrift/pull/1855
- [js] Missing class name for generated services and processors; this makes instrumentation of outbound calls (e.g. which service are we calling in to) difficult. Generating a class name for es6 enables x.constructor.name to get generated name.
- [js] Fix case where services have a method with an argument named "params", generated code generates an identifier in the "send_XXX" body named "params" which conflicts with the argument. Ensure the identifier in the body is uniquely named.
- [js] Ensure that derived services (extends XYZService) correctly call super() in their constructor.
- [ts] Ensure that derived services (extends XYZSerice) correctly specify the base class Client and Processor name
- [js] Ensure that derived service clients do not redefine private fields (output, pClass, _seqId, _reqs) and call super();
- [ts] Ensure derived service clients and processors do not redefine private fields in declaration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] pprice closed pull request #1855: Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
pprice closed pull request #1855:
URL: https://github.com/apache/thrift/pull/1855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] pprice commented on pull request #1855: Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
pprice commented on pull request #1855:
URL: https://github.com/apache/thrift/pull/1855#issuecomment-640109188
Okay; rebased on upstread, merged and force pushed. Let's give this one more go.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #1855: THRIFT-5234 Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #1855:
URL: https://github.com/apache/thrift/pull/1855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1855: Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1855:
URL: https://github.com/apache/thrift/pull/1855#issuecomment-636327295
Let's give this another try. May I ask to rebase and force-push again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1855: THRIFT-5234 Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1855:
URL: https://github.com/apache/thrift/pull/1855#issuecomment-646996272
commited 7db2d0fa46fc7724eff9e0d5b85d28010265cf55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1855: Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1855:
URL: https://github.com/apache/thrift/pull/1855#issuecomment-641582467
That looks related:
../node_modules/.bin/html-validator --file=gen-html/index.html --verbose
Error: Validator returned unexpected statuscode: 503
at Request._callback (/thrift/src/node_modules/html-validator/index.js:32:23)
at Request.self.callback (/thrift/src/node_modules/request/request.js:185:22)
at Request.emit (events.js:198:13)
at Request.<anonymous> (/thrift/src/node_modules/request/request.js:1161:10)
at Request.emit (events.js:198:13)
at IncomingMessage.<anonymous> (/thrift/src/node_modules/request/request.js:1083:12)
at Object.onceWrapper (events.js:286:20)
at IncomingMessage.emit (events.js:203:15)
at endReadableNT (_stream_readable.js:1145:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1855: Fix a number of js/ts generation issues
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1855:
URL: https://github.com/apache/thrift/pull/1855#issuecomment-638644896
Ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org