You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/19 14:09:03 UTC

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #5612: [AIRFLOW-4583] Fixes type error in GKEPodOperator

nuclearpinguin commented on a change in pull request #5612: [AIRFLOW-4583] Fixes type error in GKEPodOperator
URL: https://github.com/apache/airflow/pull/5612#discussion_r305373904
 
 

 ##########
 File path: airflow/contrib/operators/gcp_container_operator.py
 ##########
 @@ -307,7 +307,7 @@ def _set_env_from_extras(self, extras):
         else:
             # Write service account JSON to secure file for gcloud to reference
             service_key = tempfile.NamedTemporaryFile(delete=False)
-            service_key.write(keyfile_json_str)
+            service_key.write(keyfile_json_str.encode('utf-8'))
 
 Review comment:
   I think we can open another issue to unify this outside this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services