You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2026/07/27 18:24:36 UTC
[PR] Remove all Polaris references and make version a env variable [terraform-provider-iceberg]
rambleraptor opened a new pull request, #83:
URL: https://github.com/apache/terraform-provider-iceberg/pull/83
I'm taking a couple of build nits from the email thread and putting them in a single PR.
This removes all Polaris references (`grep -ri polaris` to verify). It also makes the VERSION on the build script configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove all Polaris references and make version a env variable [terraform-provider-iceberg]
Posted by "rambleraptor (via GitHub)" <gi...@apache.org>.
rambleraptor commented on code in PR #83:
URL: https://github.com/apache/terraform-provider-iceberg/pull/83#discussion_r3660439866
##########
build.sh:
##########
@@ -18,7 +18,8 @@
# --- Configuration ---
PROVIDER_NAMESPACE="apache"
PROVIDER_TYPE="iceberg"
-VERSION="1.0.0"
+# Local dev build, not a release. Override with VERSION=0.1.0 ./build.sh
+VERSION="${VERSION:-0.0.0}"
Review Comment:
I don't think so.
The only places that need the version are in the release pipeline. GoReleaser fetches the version from the tag, and the GitHub actions work takes it from git tags (if it's necessary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove all Polaris references and make version a env variable [terraform-provider-iceberg]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #83:
URL: https://github.com/apache/terraform-provider-iceberg/pull/83#discussion_r3660346075
##########
build.sh:
##########
@@ -18,7 +18,8 @@
# --- Configuration ---
PROVIDER_NAMESPACE="apache"
PROVIDER_TYPE="iceberg"
-VERSION="1.0.0"
+# Local dev build, not a release. Override with VERSION=0.1.0 ./build.sh
+VERSION="${VERSION:-0.0.0}"
Review Comment:
does CI need a corresponding change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Remove all Polaris references and make version a env variable [terraform-provider-iceberg]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #83:
URL: https://github.com/apache/terraform-provider-iceberg/pull/83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org