You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyifan279 (via GitHub)" <gi...@apache.org> on 2024/04/24 11:13:19 UTC
Re: [PR] [GLUTEN-489][BUILD] Run `mvn clean` fails without a spark profile [incubator-gluten]
zhouyifan279 commented on code in PR #5519:
URL: https://github.com/apache/incubator-gluten/pull/5519#discussion_r1577705188
##########
pom.xml:
##########
@@ -129,11 +134,9 @@
</profile>
<profile>
<id>spark-3.2</id>
- <activation>
Review Comment:
When profile java-8 is activated, all profiles that are active by default are automatically deactivated.
As a result, `delta.package.name` is undefined and we get a invalid artifactId in delta dependency.
##########
shims/pom.xml:
##########
@@ -68,31 +69,4 @@
</plugins>
</pluginManagement>
</build>
-
- <profiles>
Review Comment:
Move into parent profiles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org