You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/14 11:30:51 UTC
[GitHub] [airflow] kaxil opened a new pull request #20872: Unpin ``cattrs``
kaxil opened a new pull request #20872:
URL: https://github.com/apache/airflow/pull/20872
This was pinned because of issue mentioned in https://github.com/apache/airflow/issues/16172 . However this was fixed in 1.8.0 of cattrs by https://github.com/python-attrs/cattrs/issues/151
Changelog entry - https://cattrs.readthedocs.io/en/latest/history.html#id9
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #20872: Unpin ``cattrs``
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #20872:
URL: https://github.com/apache/airflow/pull/20872#discussion_r784804217
##########
File path: setup.cfg
##########
@@ -85,8 +85,7 @@ install_requires =
attrs>=20.0, <21.0
blinker
cached_property~=1.5;python_version<="3.7"
- # cattrs >= 1.7.0 break lineage - see https://github.com/apache/airflow/issues/16172
- cattrs~=1.1, <1.7.0
+ cattrs~=1.1
Review comment:
Is it worth having
```suggestion
cattrs~=1.1, !=1.7.*
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20872: Unpin ``cattrs``
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20872:
URL: https://github.com/apache/airflow/pull/20872#discussion_r784848671
##########
File path: setup.cfg
##########
@@ -85,8 +85,7 @@ install_requires =
attrs>=20.0, <21.0
blinker
cached_property~=1.5;python_version<="3.7"
- # cattrs >= 1.7.0 break lineage - see https://github.com/apache/airflow/issues/16172
- cattrs~=1.1, <1.7.0
+ cattrs~=1.1
Review comment:
Good idea, yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20872: Unpin ``cattrs``
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20872:
URL: https://github.com/apache/airflow/pull/20872#issuecomment-1013050672
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #20872: Unpin ``cattrs``
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #20872:
URL: https://github.com/apache/airflow/pull/20872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org