You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/10 07:44:49 UTC

[GitHub] lupesko commented on issue #11626: MXNet Model Backwards Compatibility Checker

lupesko commented on issue #11626: MXNet Model Backwards Compatibility Checker
URL: https://github.com/apache/incubator-mxnet/pull/11626#issuecomment-403731661
 
 
   Thanks for this important contribution!
   
   A not about the description, which is lacking, and should be updated as needed, rather than be left with un-relevant stuff from the template. A few examples: 
   - the issue description says "The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)"
   This issue is not tiny, and yet it has no JIRA. Please follow the guidelines and file a JIRA and update the issue name.
   - "All changes have test coverage" is not checked. I think it should be checked, or else you should add the relevant coverage.
   - I recommend you go over the issue description and update as needed. No need to leave things that are not relevant for the PR, and on the other hand add more details on bullet points that are relevant.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services