You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2023/03/10 18:16:44 UTC
[GitHub] [airflow] pierrejeambrun opened a new pull request, #30025: Git clean should work if root owned files are working tree.
pierrejeambrun opened a new pull request, #30025:
URL: https://github.com/apache/airflow/pull/30025
```
breeze release-management start-rc-process --version ${VERSION} --previous-version 2.5.1
```
Can fail if there are root owned files in the working tree. This can happen especially in the `.logs` folder.
This run the `git clean` as root to not fail with a 'PermissionError' and make sure that all files are actually deleted before going further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30025: Git clean should work if root owned files are in the working tree
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30025:
URL: https://github.com/apache/airflow/pull/30025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pierrejeambrun commented on pull request #30025: Git clean should work if root owned files are in the working tree
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #30025:
URL: https://github.com/apache/airflow/pull/30025#issuecomment-1464908380
Yep this is better.
I just update the PR to always do a `fix_ownership` before `git clean -fxd`. I don't think we need the `use_root` option yet, as it works fine without having to use root (even on linux).
The only thing is that I had to add `.mypy_cach` and `dev` to the folder that we check for fixing permission. (Some files were root owned on my end here and the command would fail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] skyboi1233 commented on pull request #30025: Git clean should work if root owned files are in the working tree
Posted by "skyboi1233 (via GitHub)" <gi...@apache.org>.
skyboi1233 commented on PR #30025:
URL: https://github.com/apache/airflow/pull/30025#issuecomment-1465001724
I am not ask for any if this information are asking for any Of thus changes
Sent from Yahoo Mail for iPhone
On Saturday, March 11, 2023, 2:00 PM, Jarek Potiuk ***@***.***> wrote:
Merged #30025 into main.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30025: Git clean should work if root owned files are in the working tree
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30025:
URL: https://github.com/apache/airflow/pull/30025#issuecomment-1464209733
We should not have sudo on MacOS - it's not necessary and will require you to provide the password (unles you - insecurely - set your sudo to be passwordless) which is a bit annoying.
Also maybe we should simply use the existing "fix_ownership" methods we already use in `breeze ci fix-ownership` command and run it before git-clean (and add simillar `--use-sudo` flag)? https://github.com/apache/airflow/blob/b9c231ceb0f3053a27744b80e95f08ac0684fe38/dev/breeze/src/airflow_breeze/commands/ci_commands.py#L151
The nice thing with that solution is that it uses docker to fix the ownership, which does not require you to provide the password for sudo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30025: Git clean should work if root owned files are in the working tree
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30025:
URL: https://github.com/apache/airflow/pull/30025#issuecomment-1465000774
Cool. That works !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30025: Git clean should work if root owned files are in the working tree
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30025:
URL: https://github.com/apache/airflow/pull/30025#issuecomment-1464863878
One more comment why "sudo" with any "git" command is not best -> it might eventually modify .git content - not sure if clean does, but many git commands do, and when you run it with sudo, it might leave "root" owned file in .git directory - which is even worse problem to have :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org