You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by salbahra <gi...@git.apache.org> on 2017/08/23 18:06:14 UTC
[GitHub] cordova-plugin-file pull request #216: CB-13208: (windows) Fix `readAsBinary...
GitHub user salbahra opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/216
CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range
### Platforms affected
Windows
### What does this PR do?
Change `readAsBinaryString` on `FileReader` for Windows to use a stream which seeks to the start position and only reads until the requested end instead of reading the entire file to a buffer then slicing the requested fragment.
### What testing has been done on this change?
Plugin change has been tested on Windows as that's the only platform affected.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Mimeo/cordova-plugin-file master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #216
----
commit 6da561fe7610fa8e4751d1d867a16af75c64019a
Author: Samer Albahra <sa...@gmail.com>
Date: 2017-08-23T18:03:01Z
Change `readAsBinaryString` on Windows to use a stream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file issue #216: CB-13208: (windows) Fix `readAsBinaryString`...
Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/216
Did I get this right that this basically adds an additional step in between where only the requested part is read into `buffer`?
There seems to be a conflict now, can you fix that by rebasing your changes?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-file issue #216: CB-13208: (windows) Fix `readAsBinaryString`...
Posted by salbahra <gi...@git.apache.org>.
Github user salbahra commented on the issue:
https://github.com/apache/cordova-plugin-file/pull/216
That is correct, I am using the other read methods as a template.
The merge conflicts should be resolved now.
Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org