[GitHub] [opennlp] jzonthemtn commented on a diff in pull request #426: OPENNLP-1387 : Fix alphaNumOpt in tokenizer example

[GitBox <gi...@apache.org>]

jzonthemtn commented on code in PR #426:
URL: https://github.com/apache/opennlp/pull/426#discussion_r1003288846


##########
opennlp-docs/src/docbkx/tokenizer.xml:
##########
@@ -258,37 +258,39 @@ Arguments description:
 				To train the english tokenizer use the following command:
 				<screen>
 			    <![CDATA[
-$ opennlp TokenizerTrainer -model en-token.bin -alphaNumOpt -lang en -data en-token.train -encoding UTF-8
+$ opennlp TokenizerTrainer -model en-token.bin -alphaNumOpt isAlphaNumOpt -lang en -data en-token.train -encoding UTF-8

Review Comment:
   Looking at this again, should this be `true` instead of `isAlphaNumOpt`? Like:
   
   ```
   $ opennlp TokenizerTrainer -model en-token.bin -alphaNumOpt true -lang en -data en-token.train -encoding UTF-8
   ```
   
   Looking at `TrainingParams.java`, `getAlphaNumOpt()` returns a `Boolean` and defaults to `false`. Since it defaults to `false`, I guess it makes sense for the example to be `true`...?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org