You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/11/21 21:10:39 UTC
Review Request 64001: Made sure all true allocator agent updates
return correct status.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
The allocator method 'updateSlave' can be used to modify either an
agent's capabilities, its total resources, or both. It is expected
that this method return 'true' whenever a change occurred.
This patch fixes an issue where if the method as implemented in the
hierarchical allocator was called with new capabilities but the
current total resources, 'false' would have been returned, even though
the capabilities where updated.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629
Diff: https://reviews.apache.org/r/64001/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64001: Made sure all true allocator agent updates
trigger allocations.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/
-----------------------------------------------------------
(Updated Nov. 27, 2017, 11:51 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fixed commit message.
Summary (updated)
-----------------
Made sure all true allocator agent updates trigger allocations.
Repository: mesos
Description (updated)
-------
The allocator method 'updateSlave' can be used to modify either an
agent's capabilities, its total resources, or both. It is expected
that this method triggers an allocation whenever a change occurred.
This patch fixes an issue where if the method as implemented in the
hierarchical allocator was called with new capabilities but the current
total resources, not allocation would have been triggered, even though
the capabilities were updated.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629
Diff: https://reviews.apache.org/r/64001/diff/2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 64001: Made sure all true allocator agent updates
return correct status.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/#review191877
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Nov. 24, 2017, 3:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64001/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2017, 3:07 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator method 'updateSlave' can be used to modify either an
> agent's capabilities, its total resources, or both. It is expected
> that this method return 'true' whenever a change occurred.
>
> This patch fixes an issue where if the method as implemented in the
> hierarchical allocator was called with new capabilities but the
> current total resources, 'false' would have been returned, even though
> the capabilities where updated.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629
>
>
> Diff: https://reviews.apache.org/r/64001/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64001: Made sure all true allocator agent updates
return correct status.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/#review191876
-----------------------------------------------------------
Ship it!
Please correct the commit message to omit mentioning `return`.
- Alexander Rukletsov
On Nov. 24, 2017, 2:07 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64001/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2017, 2:07 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator method 'updateSlave' can be used to modify either an
> agent's capabilities, its total resources, or both. It is expected
> that this method return 'true' whenever a change occurred.
>
> This patch fixes an issue where if the method as implemented in the
> hierarchical allocator was called with new capabilities but the
> current total resources, 'false' would have been returned, even though
> the capabilities where updated.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629
>
>
> Diff: https://reviews.apache.org/r/64001/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 64001: Made sure all true allocator agent updates
return correct status.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64001/
-----------------------------------------------------------
(Updated Nov. 24, 2017, 3:07 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Rebased.
Repository: mesos
Description
-------
The allocator method 'updateSlave' can be used to modify either an
agent's capabilities, its total resources, or both. It is expected
that this method return 'true' whenever a change occurred.
This patch fixes an issue where if the method as implemented in the
hierarchical allocator was called with new capabilities but the
current total resources, 'false' would have been returned, even though
the capabilities where updated.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp cfeeb3bfa3ad7d78ff6e22cfc4adb1f0efa05629
Diff: https://reviews.apache.org/r/64001/diff/2/
Changes: https://reviews.apache.org/r/64001/diff/1-2/
Testing
-------
`make check`
Thanks,
Benjamin Bannier