You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "monkwire (via GitHub)" <gi...@apache.org> on 2024/03/20 22:41:06 UTC
[PR] Split arrow_cast::cast::list into it's own submodule [arrow-rs]
monkwire opened a new pull request, #5537:
URL: https://github.com/apache/arrow-rs/pull/5537
# Which issue does this PR close?
This issue addresses part of #5125.
# Rationale for this change
This PR moves the list handling logic from `arrow_cast::cast` into private submodule `arrow_cast::cast::list`, making `arrow_cast::cast` smaller and more manageable.
# What changes are included in this PR?
`arrow-rs/arrow-cast/src/cast.rs/` is now `arrow-rs/arrow-cast/src/cast/mod.rs`. The list handling functions from `arrow_cast::cast` now live in `arrow-rs/arrow-cast/src/cast/list.rs`.
# Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Split arrow_cast::cast::list into it's own submodule [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #5537:
URL: https://github.com/apache/arrow-rs/pull/5537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Split arrow_cast::cast::list into it's own submodule [arrow-rs]
Posted by "monkwire (via GitHub)" <gi...@apache.org>.
monkwire commented on code in PR #5537:
URL: https://github.com/apache/arrow-rs/pull/5537#discussion_r1533114365
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -37,6 +37,9 @@
//! assert_eq!(7.0, c.value(2));
//! ```
+pub mod list;
Review Comment:
Good call. Ty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Split arrow_cast::cast::list into it's own submodule [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5537:
URL: https://github.com/apache/arrow-rs/pull/5537#discussion_r1533046301
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -37,6 +37,9 @@
//! assert_eq!(7.0, c.value(2));
//! ```
+pub mod list;
Review Comment:
```suggestion
mod list;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org