[GitHub] [incubator-superset] rusackas commented on pull request #11708: refactor: WIP Simplifying tabOverride logic in control sections

[GitBox <gi...@apache.org>]

rusackas commented on pull request #11708:
URL: https://github.com/apache/incubator-superset/pull/11708#issuecomment-736292498


   > Instead of adding a `customize` option, I'd be more enthusiastic on getting rid of the "`renderTrigger` implies data tab" logic. To really keep things simple, we should just always default things to be on the `customize` tab and require explicit override if people want to display things in the `Data` tab (or other way around if it makes more sense).
   > 
   > But this change is probably safe since I didn't see any use of `tabOverride` at the control item level anymore.
   
   Yep... I had an itchy trigger finger to remove that behavior entirely, but didn't want to cause any weird regressions. I'll do that in another PR once we've made some more updates on the superset-ui side and merged them in.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org