You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ra...@apache.org on 2018/11/13 14:30:34 UTC
carbondata git commit: [CARBONDATA-3075] Select Filter fails for
Legacy store if DirectVecorFill is enabled
Repository: carbondata
Updated Branches:
refs/heads/master 109184848 -> 0ccbe1b4d
[CARBONDATA-3075] Select Filter fails for Legacy store if DirectVecorFill is enabled
Why this PR?
When isDirectVectorFill is set to true, Select filter fails in Legacy Store throwing UnsupportedOperationException
Solution:
Set isDirectVectorFill to false for Legacy store
This closes #2896
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/0ccbe1b4
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/0ccbe1b4
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/0ccbe1b4
Branch: refs/heads/master
Commit: 0ccbe1b4dd26045c473e95327b7c0725790bf521
Parents: 1091848
Author: Indhumathi27 <in...@gmail.com>
Authored: Mon Nov 5 16:12:24 2018 +0530
Committer: ravipesala <ra...@gmail.com>
Committed: Tue Nov 13 20:00:24 2018 +0530
----------------------------------------------------------------------
.../core/scan/executor/impl/AbstractQueryExecutor.java | 5 +++++
1 file changed, 5 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/0ccbe1b4/core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java b/core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
index 2bd243b..710fbe3 100644
--- a/core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
+++ b/core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
@@ -230,6 +230,11 @@ public abstract class AbstractQueryExecutor<E> implements QueryExecutor<E> {
updateColumns(queryModel, fileFooter.getColumnInTable(), blockInfo.getFilePath());
filePathToSegmentPropertiesMap.put(blockInfo.getFilePath(), segmentProperties);
}
+ LOGGER.warn("Skipping Direct Vector Filling as it is not Supported "
+ + "for Legacy store prior to V3 store");
+ if (blockletDetailInfo.isLegacyStore()) {
+ queryModel.setDirectVectorFill(false);
+ }
readAndFillBlockletInfo(tableBlockInfos, blockInfo,
blockletDetailInfo, fileFooter, segmentProperties);
} else {