You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/06/22 04:40:57 UTC

[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #962: [#961] improvement(coordinator): [Improvement] [Minor] Improve Coordinator Log Format.

zuston commented on code in PR #962:
URL: https://github.com/apache/incubator-uniffle/pull/962#discussion_r1237983152


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/web/servlet/DecommissionServlet.java:
##########
@@ -42,9 +42,7 @@ protected Response<Object> handlePost(HttpServletRequest req, HttpServletRespons
       return Response.fail("Parameter[serverIds] should not be null!");
     }
     ClusterManager clusterManager = coordinator.getClusterManager();
-    params.getServerIds().forEach((serverId) -> {
-      clusterManager.decommission(serverId);
-    });
+    params.getServerIds().forEach(clusterManager::decommission);

Review Comment:
   Emm... This is not related with this issue. Right? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org