You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/01/26 16:29:27 UTC
[GitHub] codecov-io commented on issue #529: SCB-1059 Optimize quota plugin
codecov-io commented on issue #529: SCB-1059 Optimize quota plugin
URL: https://github.com/apache/servicecomb-service-center/pull/529#issuecomment-457844623
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=h1) Report
> Merging [#529](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/80a0eb7a76407198c2d2fb54009dfa1cdf09cfd3?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `79.45%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 59.39% 59.46% +0.06%
==========================================
Files 172 175 +3
Lines 14266 14335 +69
==========================================
+ Hits 8474 8525 +51
- Misses 5200 5217 +17
- Partials 592 593 +1
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/plugin/pkg/quota/buildin/common.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvYnVpbGRpbi9jb21tb24uZ28=) | `23.52% <0%> (+0.67%)` | :arrow_up: |
| [server/plugin/pkg/quota/buildin/counter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvYnVpbGRpbi9jb3VudGVyLmdv) | `100% <100%> (ø)` | |
| [server/plugin/pkg/quota/buildin/buildin.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvYnVpbGRpbi9idWlsZGluLmdv) | `15.78% <100%> (+4.67%)` | :arrow_up: |
| [server/plugin/pkg/quota/counter/counter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvY291bnRlci9jb3VudGVyLmdv) | `100% <100%> (ø)` | |
| [server/plugin/pkg/quota/counter/event.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcXVvdGEvY291bnRlci9ldmVudC5nbw==) | `69.04% <69.04%> (ø)` | |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `67.16% <0%> (-10.45%)` | :arrow_down: |
| [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `61.53% <0%> (-3.85%)` | :arrow_down: |
| [server/service/tag.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `67.4% <0%> (-0.56%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/529/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=footer). Last update [80a0eb7...8b4fa71](https://codecov.io/gh/apache/servicecomb-service-center/pull/529?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services