You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2022/02/08 15:27:00 UTC
[jira] [Comment Edited] (CASSANDRA-17287) Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
[ https://issues.apache.org/jira/browse/CASSANDRA-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488945#comment-17488945 ]
Ekaterina Dimitrova edited comment on CASSANDRA-17287 at 2/8/22, 3:26 PM:
--------------------------------------------------------------------------
Seems like what I hit with the CCM tagging the other day.
Look here - CASSANDRA-17351
I suspect it is the different virtual environment.
By the way, did you also see the comment in Circle config that when adding new stuff to requirements.txt it is good to rebuild images?
[https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L432-L435]
was (Author: e.dimitrova):
Seems like what I hit with the CCM tagging the other day.
Look here - CASSANDRA-17351
I suspect it is the different virtual environment.
By the way, did you also see the comment in Circle config that when adding new stuff to requirements.txt it is good to rebuild images?
https://github.com/apache/cassandra/blob/trunk/.circleci/config.yml#L432-L435
> Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
> ------------------------------------------------------
>
> Key: CASSANDRA-17287
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17287
> Project: Cassandra
> Issue Type: Task
> Components: CQL/Interpreter
> Reporter: Brad Schoening
> Assignee: Brad Schoening
> Priority: Normal
> Fix For: 4.x
>
> Attachments: CQLSH sample query.jpg
>
>
> The module wcwidth implements the same Markus Kuhn algorithm defined in POSIX.1-2008 to return the number of cells a unicode string is expected to occupy.
> The module wcwidth is used by hundreds of libraries including pytest and prompt-toolkit (used in ipython). It replaces 379 lines of bespoke code in cqlshlib.
> {quote}from wcwidth import wcswidth # at [https://pypi.org/project/wcwidth/]
> print(wcswidth('コンニチハ'))
> 10
> {{from cqlshlib.wcwidth import wcswidth as cql_wcswidth}}
> print(cql_wcswidth('コンニチハ'))
> 10
> {quote}
> wcwidth appears to be used only by one line in formatting.py:
> return bval if colormap is NO_COLOR_MAP else color_text(bval, colormap, wcwidth.wcswidth(bval))
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org