You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2018/03/15 21:11:19 UTC
Review Request 66101: Added a helper to parse ContainerID.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66101/
-----------------------------------------------------------
Review request for mesos and Sagar Patwardhan.
Bugs: MESOS-8534
https://issues.apache.org/jira/browse/MESOS-8534
Repository: mesos
Description
-------
Added a helper to parse ContainerID.
Diffs
-----
src/common/protobuf_utils.hpp b33d126eafb214e19911801500b241aa5e0e57b1
src/common/protobuf_utils.cpp e0609b6154409d24ee99365feeffbdabe90d4e67
src/tests/protobuf_utils_tests.cpp 5fd45566ee90e218847fe5f0bfb174ec0d6999b9
Diff: https://reviews.apache.org/r/66101/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 66101: Added a helper to parse ContainerID.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66101/#review199297
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65987', '66101']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66101
Relevant logs:
- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66101/logs/mesos-tests-cmake-stdout.log):
```
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(415): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(437): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(438): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(460): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(461): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(500): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
D:\DCOS\mesos\mesos\src\java\jni\convert.cpp(501): warning C4267: 'argument': conversion from 'size_t' to 'jsize', possible loss of data [D:\DCOS\mesos\src\java\mesos-java.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (29) ->
(ClCompile target) ->
D:\DCOS\mesos\mesos\src\master\validation.cpp(1508): error C2001: newline in constant [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2146: syntax error: missing ')' before identifier 'containers' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2146: syntax error: missing ';' before identifier 'containers' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2065: 'containers': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2143: syntax error: missing ';' before '!' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2065: 'joining': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2001: newline in constant [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2015: too many characters in constant [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2146: syntax error: missing ';' before identifier 'parent' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2065: 'parent': undeclared identifier [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1509): error C2143: syntax error: missing ';' before 'constant' [D:\DCOS\mesos\src\mesos.vcxproj]
D:\DCOS\mesos\mesos\src\master\validation.cpp(1510): error C2143: syntax error: missing ';' before '}' [D:\DCOS\mesos\src\mesos.vcxproj]
214 Warning(s)
12 Error(s)
Time Elapsed 00:15:00.44
```
- Mesos Reviewbot Windows
On March 15, 2018, 9:11 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66101/
> -----------------------------------------------------------
>
> (Updated March 15, 2018, 9:11 p.m.)
>
>
> Review request for mesos and Sagar Patwardhan.
>
>
> Bugs: MESOS-8534
> https://issues.apache.org/jira/browse/MESOS-8534
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a helper to parse ContainerID.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp b33d126eafb214e19911801500b241aa5e0e57b1
> src/common/protobuf_utils.cpp e0609b6154409d24ee99365feeffbdabe90d4e67
> src/tests/protobuf_utils_tests.cpp 5fd45566ee90e218847fe5f0bfb174ec0d6999b9
>
>
> Diff: https://reviews.apache.org/r/66101/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>