[jira] [Commented] (GEODE-981) Suspect string: NPE in Message.clear()

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154526#comment-15154526 ] 

ASF subversion and git services commented on GEODE-981:
-------------------------------------------------------

Commit ab9cedf8f253e3c049138df282352dd28c0b252a in incubator-geode's branch refs/heads/develop from [~bschuchardt]
[ https://git-wip-us.apache.org/repos/asf?p=incubator-geode.git;h=ab9cedf ]

GEODE-981: NPE in Message.clear()

This fixes the NPE and adds a unit test for it.  I also did some cleanup
of Message, removing unused methods and old commented out code and
changing the earlyAck byte to be "flags" and not allow external
manipulation of the byte's bits.


> Suspect string: NPE in Message.clear()
> --------------------------------------
>
>                 Key: GEODE-981
>                 URL: https://issues.apache.org/jira/browse/GEODE-981
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Bruce Schuchardt
>            Assignee: Bruce Schuchardt
>
> A test failed with a suspect string in Message.clear()
> [warning 2015/11/06 21:45:34.375 PST bridgegemfire5_w2-gst-pnq-05_1812 <Function Execution Processor5> tid=0x11e] Task failed with exception
> java.lang.NullPointerException
>         at com.gemstone.gemfire.internal.cache.tier.sockets.Message.clear(Message.java:509)
>         at com.gemstone.gemfire.internal.cache.execute.ServerToClientFunctionResultSender65.writeFunctionExceptionResponse(ServerToClientFunctionResultSender65.java:260)
>         at com.gemstone.gemfire.internal.cache.execute.ServerToClientFunctionResultSender.setException(ServerToClientFunctionResultSender.java:299)
>         at com.gemstone.gemfire.internal.cache.execute.PartitionedRegionFunctionResultSender.setException(PartitionedRegionFunctionResultSender.java:315)
>         at com.gemstone.gemfire.internal.cache.execute.AbstractExecution.handleException(AbstractExecution.java:628)
>         at com.gemstone.gemfire.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:398)
>         at com.gemstone.gemfire.internal.cache.execute.AbstractExecution$1.run(AbstractExecution.java:302)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at com.gemstone.gemfire.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:658)
>         at com.gemstone.gemfire.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1115)
>         at java.lang.Thread.run(Thread.java:745)
> We need a fix for this and a unit test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)